wp-trackback.php breaks API 'trackback_post' action functionality

[jminard]

In the file wp-trackback.php at line 88 and 89 it reads:

trackback_response(0);
do_action('trackback_post', $comment_ID);

but the function trackback_response() calls a die() in it, thus the trackback_post actions are never applied.

Solution: Flip the two lines. All better.

[michel v]

The die() command only ever gets executed when trackback_response() is called with a first parameter that is not 0.
So if functions in the trackback_post hook does not get executed, then it is either a problem with one of the functions, or a problem with WP's API. But either way, it's not a problem with the order of these lines.

[jminard]

from wp-includes/functions.php:

trackback - reply
function trackback_response($error = 0, $error_message = ) {

if ($error) {

echo '<?xml version="1.0" encoding="iso-8859-1"?'.">\n";
echo "<response>\n";
echo "<error>1</error>\n";
echo "<message>$error_message</message>\n";
echo "</response>";

} else {

echo '<?xml version="1.0" encoding="iso-8859-1"?'.">\n";
echo "<response>\n";
echo "<error>0</error>\n";
echo "</response>";

}
die();

}

I can pretty clearly see that this function calls "die()" no matter what you pass it.

Thus, it calls die() and do_action() never happens.

I just checked the download from 1.2.2 and both sections of code have not changed, so this is still an issue.

[MC_incubus]

Another solution could be to move the die() into the if($error) { } position.