Make WordPress Core

Changes between Initial Version and Version 5 of Ticket #60524


Ignore:
Timestamp:
02/14/2024 08:41:59 AM (3 months ago)
Author:
afercia
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #60524

    • Property Keywords needs-patch added
    • Property Owner set to rcreators
    • Property Status changed from new to assigned
    • Property Milestone changed from Awaiting Review to 6.5
  • Ticket #60524 – Description

    initial v5  
    22See #54370 / [57602]
    33
    4 In [53027], a bug was fixed where newly generated cropped images didn't copied over some meta data from the original image like the alt text and caption.
     4In [53027], a bug was fixed where newly generated cropped images didn't copy over some meta data from the original image like the alt text and caption.
    55
    66The code that fixed the bug was added in the `wp_ajax_crop_image()` function but it turns out it was added in the `default` case of [https://github.com/WordPress/wordpress-develop/blob/8c6a1db3120ea63165b4485c56820483403aefc1/src/wp-admin/includes/ajax-actions.php#L4021-L4133 the big switch statement] in that function.
     
    1616
    1717To reproduce:
    18 - Set Twenty Twenty-One as active theme so that the Customiser is available.
     18- Set Twenty Twenty-One as active theme so that the Customizer is available.
    1919- Go to the Customizer > Site Identity.
    2020- Set a Logo image: make sure to select an image that is large enough to be cropped and that does have an alt text.
    2121- Once the image gets cropped and set as logo, open the Media Library again.
    22 - Observe there's a new copped image.
     22- Observe there's a new cropped image.
    2323- Select the cropped image and observe in the right side of the media modal dialog that the original alt text (and caption if originally present) has been copied to the new image.
    2424- Close the media modal dialog.
    2525- In the Customizer set a Site Icon, repeating the steps above.
    2626- Once the image gets cropped and set as site icon, open the Media Library again.
    27 - Observe there's a new copped image.
     27- Observe there's a new cropped image.
    2828- Select the new image and observe the original alt text (and caption if any) hasn't been copied to the new image.