Make WordPress Core

Opened 18 years ago

Closed 18 years ago

Last modified 2 years ago

#6054 closed defect (bug) (fixed)

"Saved at [time]" status box shouldn't shift page

Reported by: lloydbudd's profile lloydbudd Owned by: mdawaffe's profile mdawaffe
Milestone: 2.5 Priority: normal
Severity: normal Version: 2.5
Component: General Keywords: has-patch has-unit-tests
Focuses: Cc:

Description

"Saved at [time]" status box shouldn't shift page

ENV: WP trunk r7117

I don't know if this is only because it isn't styled yet.

"Saved at [time]" status box shouldn't shift parts of the page down. This is distracting for a person. It should appear in an existing space for it.

Attachments (1)

6054.diff (4.5 KB) - added by mdawaffe 18 years ago.

Download all attachments as: .zip

Change History (9)

#1 @mdawaffe
18 years ago

  • Status changed from new to assigned

But is it distracting for a robot? I think not.

Maybe iammattthomas can advise.

#2 @mdawaffe
18 years ago

How about we put it in the sidebar?

It was under the post box before because that's where the save buttons were. Now the save buttons are in the sidebar, so autosave notices should go there too.

Attached make the message more subtle and puts it by the save buttons. It shifts the layout of the sidebar a bit still. Good? Bad? The sidebar is also shifted a bit when the preview link is added; this has been the case for a while.

The main content layout is still shifted a bit by the permalink line. This also has been the case for a while.

@mdawaffe
18 years ago

#3 @lloydbudd
18 years ago

  • Keywords has-patch added

mdawaffe, I think this addresses the issue, primarily by being more subtle, but it is also good to have it in the vicinity to have the state near the Save button, b/c that matches expectations and is common in other applications.

#4 @ryan
18 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [7145]) Autosave notice styling from mdawaffe. fixes #6054

#5 @mdawaffe
18 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#6 @mdawaffe
18 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

oops: wrong ticket

This ticket was mentioned in PR #6203 on WordPress/wordpress-develop by @dmsnell.


2 years ago
#7

  • Keywords has-unit-tests added

Alternative to #6054

When reaching text nodes that require creating elements during active format reconstruction, aborts the HTML Processor.

This prevents progressing into a document where the text nodes would change the structure and affect breadcrumbs. Until the HTML Processor properly supports text nodes this makes it possible to continue operating safely.

@dmsnell commented on PR #6203:


2 years ago
#8

Closing this because I don't think that the approach is sound. Favoring the more comprehensive approach of tracking every token in the HTML Processor, in #6054

Note: See TracTickets for help on using tickets.