Make WordPress Core

Opened 4 months ago

Closed 4 months ago

Last modified 4 months ago

#60542 closed defect (bug) (fixed)

Interactivity API: Remove data-wp-interactive object for core/router.

Reported by: cbravobernal's profile cbravobernal Owned by: swissspidy's profile swissspidy
Milestone: 6.5 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch commit
Focuses: Cc:

Description

In https://github.com/WordPress/wordpress-develop/commit/6345e2494793cad4294b792fc6ddc54a2bdeb94d , was added the support of
data-wp-interactive="myPlugin" apart from data-wp-interactive='{"namespace":"myPlugin"}'

In order to keep consistency with the rest of the blocks, that were updated in
https://github.com/WordPress/gutenberg/pull/58943, and being Core as a guide for standards, this ticket updates the core/router namespace accordingly.

Change History (6)

@gziolo commented on PR #6111:


4 months ago
#2

What was the original ticket where the same functionality landed? It would be better to link it instead when refactoring code unless it's a bug. Still, we would need the original commit and ticket to reference in the commit message.

@cbravobernal commented on PR #6111:


4 months ago
#3

The code that implements that change is part of the interactivity package, that landed in 17.7

Was implemented here:

And commited in this ticket:

#4 @gziolo
4 months ago

  • Component changed from General to Editor
  • Keywords commit added
  • Milestone changed from Awaiting Review to 6.5

#5 @swissspidy
4 months ago

  • Owner set to swissspidy
  • Resolution set to fixed
  • Status changed from new to closed

In 57646:

Interactivity API: Use string instead of object in data-wp-interactive attribute.

The server directive processing, integrated in [57563], supports a simplified format for passing the namespace to data-wp-interactive.

Props cbravobernal, gziolo.
Fixes #60542.
See #60356.

Note: See TracTickets for help on using tickets.