#60542 closed defect (bug) (fixed)
Interactivity API: Remove data-wp-interactive object for core/router.
Reported by: | cbravobernal | Owned by: | swissspidy |
---|---|---|---|
Milestone: | 6.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Editor | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
In https://github.com/WordPress/wordpress-develop/commit/6345e2494793cad4294b792fc6ddc54a2bdeb94d , was added the support of
data-wp-interactive="myPlugin"
apart from data-wp-interactive='{"namespace":"myPlugin"}'
In order to keep consistency with the rest of the blocks, that were updated in
https://github.com/WordPress/gutenberg/pull/58943, and being Core as a guide for standards, this ticket updates the core/router namespace accordingly.
Change History (6)
This ticket was mentioned in PR #6111 on WordPress/wordpress-develop by @cbravobernal.
7 months ago
#1
- Keywords has-patch added
7 months ago
#2
What was the original ticket where the same functionality landed? It would be better to link it instead when refactoring code unless it's a bug. Still, we would need the original commit and ticket to reference in the commit message.
@cbravobernal commented on PR #6111:
7 months ago
#3
The code that implements that change is part of the interactivity package, that landed in 17.7
Was implemented here:
And commited in this ticket:
#4
@
7 months ago
- Component changed from General to Editor
- Keywords commit added
- Milestone changed from Awaiting Review to 6.5
#5
@
7 months ago
- Owner set to swissspidy
- Resolution set to fixed
- Status changed from new to closed
In 57646:
Trac ticket: https://core.trac.wordpress.org/ticket/60542
Gutenberg backport: https://github.com/WordPress/gutenberg/pull/59030