Make WordPress Core

Opened 3 months ago

Closed 3 months ago

Last modified 3 months ago

#60555 closed task (blessed) (fixed)

Update the version of Node.js used in the Codespaces container.

Reported by: itschristiandale's profile itschristiandale Owned by: desrosj's profile desrosj
Milestone: 6.5 Priority: normal
Severity: normal Version: 6.5
Component: Build/Test Tools Keywords: has-patch commit fixed-major
Focuses: Cc:

Description

Wordpress does not build with Node.js 16. This change fixes this issue by using Node.js 20 (lts) for Github Codespaces.

Change History (12)

This ticket was mentioned in PR #6125 on WordPress/wordpress-develop by christian-dale.


3 months ago
#1

  • Keywords has-patch added

…s container.

Wordpress does not build with Node.js 16. This change fixes this issue by using Node.js 20 (lts) for Github Codespaces.

Trac ticket: https://core.trac.wordpress.org/ticket/60555

#2 @huzaifaalmesbah
3 months ago

Good Catch. Thanks for Report and PR.

#3 @itschristiandale
3 months ago

I managed to make this commit to the trunk branch of my fork, so I had to delete the repo and make a new fork. This is why the pull-request is set to closed on Github. I’m new to this hehe.

Last edited 3 months ago by itschristiandale (previous) (diff)

@desrosj commented on PR #6125:


3 months ago
#4

Hi @christian-dale,

Did you mean to close this out? I had this marked to circle back to, but noticed it's closed out now.

@itschristiandale commented on PR #6125:


3 months ago
#5

Hello @desrosj,

I apologize for the confusion here. I managed to make this commit to the «trunk» brach of my fork, so it seemed the easiest way to fix my repo was to delete it and make a new fork with correct branching.

This seemed to have caused the pull-request to be closed, but it is still open for merging :)

#6 @desrosj
3 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 6.5
  • Owner set to desrosj
  • Status changed from new to assigned
  • Type changed from defect (bug) to task (blessed)

Related: #59663.

#7 @desrosj
3 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 57667:

Build/Test Tools: Bump the Node.js version for Codespaces.

This bumps the version of Node.js used in GitHub Codespaces from 16 to 20.

Follow up to [57212].

Props itschristiandale, huzaifaalmesbah.
Fixes #60555.

#8 @desrosj
3 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening because this will need to be backported to the 6.4 branch.

@desrosj commented on PR #6125:


3 months ago
#9

Thanks! I am not sure how to really test this without merging. It seems straightforward enough, though. So I've gone and committed it in https://core.trac.wordpress.org/changeset/57667. I tested, and it seems to work as expected.

I'm curious, do you use Codespaces for wordpress-develop? And if so, how often, and what do you typically use it for?

We added support for Codespaces, but I have not seen anyone use it as their preferred tool.

@itschristiandale commented on PR #6125:


3 months ago
#10

I just recently started contributing to the Wordpress codebase, so I thought the easiest way to start testing would be by using GitHub Codespaces. The build processed failed, and that's why this was my first commit.

I can't say Github Codespaces is my preferred dev environment, but it very useful for quick prototyping.

#11 @desrosj
3 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 57672:

Build/Test Tools: Bump the Node.js version for Codespaces.

This bumps the version of Node.js used in GitHub Codespaces from 16 to 20.

Follow up to [57212].

Merges [57667] to the 6.4 branch.

Props itschristiandale, huzaifaalmesbah.
Fixes #60555.

@desrosj commented on PR #6125:


3 months ago
#12

Great! Thanks for the context and the contribution! 😃

Note: See TracTickets for help on using tickets.