Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #60575, comment 17


Ignore:
Timestamp:
02/26/2024 09:19:12 AM (3 months ago)
Author:
luisherranz
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #60575, comment 17

    initial v1  
    11> what's your take on simply renaming the function for more consistency?
    22
    3 I know you that you mean consistency with other WordPress functions, but to me it's more important to keep consistency with what the function is replacing: `data-wp-context`. So `data_wp_context` is the most consistent name in my opinion. It's also the only one where people don't need to remember one extra concept because it's a direct mental link `data-wp-context` <-> `data_wp_context`.
     3I know that you mean consistency with other WordPress functions, but to me, it's more important to keep consistency with what the function is replacing: `data-wp-context`. So `data_wp_context` is the most consistent name in my opinion. It's also the only one where people don't need to remember one extra concept because it's a direct mental link `data-wp-context` <-> `data_wp_context`.
    44
    5 I know that's not the answer that you're looking for, so just to understand the issue better, may I know what type of problems do you envision if we follow that path and use `data_wp_directivename` for these helpers?
     5I know that's not the answer that you're looking for, so just to understand the issue better, may I know what type of problems you envision if we follow that path and use `data_wp_directivename` for these helpers? What's at stake here?