When plugin upload fails, add a link to return to plugin installer page

[Presskopp]

When for any reason a plugin upload fails (Only .zip archives may be uploaded. / Incompatible Archive.) you will be confronted with an error and there is no way out. Of course, you can use the browser's built-in back button, but still it would be nice to offer an additional link "Go to Plugin Installer" or "Back to Plugin Installer" (leading to wp-admin/plugin-install.php)

[Presskopp]

Oops I crashed the formatting, sorry.

[swissspidy]

Sounds reasonable to me.

[smub]

+1 - I agree this would definitely help improve UX for beginners & non-techy users. I wonder if there are other error screens like these without an action link that can benefit from it.

[pmbaldha]

This feature is already implemented in the current WordPress core.
​https://nimb.ws/cqlrgOv

[swissspidy]

@pmbaldha This ticket is about the error message you get when the file is invalod. For example, try renaming a TXT file to ZIP und upload that. You‘ll get an error message without a back button

[pmbaldha]

Patch file

[pmbaldha]

@swissspidy Can you please verify and test the attached patch file? Thanks Swiss!

[pmbaldha]

@smub I have opened the ticket https://core.trac.wordpress.org/ticket/60644 for the theme installation fails error screen.

[swissspidy]

No need for a separate ticket, we can do that here, especially since the PR already does that.

[swissspidy]

#60644 was marked as a duplicate.

[pmbaldha]

@swissspidy 

This ticket is for an invalid zip file uploaded. Screenshot: ​https://nimb.ws/hItAqJb. This issue is resolved by this PR.

The other ticket is for the uploaded valid zip file, which is not a valid theme file. Screenshot: ​https://nimb.ws/GqC3Y17. This issue is not resolved in this PR.

I know that we shouldn't write duplicate tickets. 

so, both issues are different. Can you please reopen the other ticket?

[swissspidy]

I see, thanks for clarifying. Still, I think we can address this together to make the error messaging consistent. Should be a trivial addition to the existing PR.

[pmbaldha]

I have debugged the issue on another ticket. The code exists in the codebase, but it is not working. It is not a trivial addition to existing PR.

The other ticket requires a different set of test instructions too.

Let me know what the next step is.

[swissspidy]

If you feel strongly about it I'll just reopen it.

[aneeshd16]

Test report for patch 60578

[aneeshd16]

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/60578/60578.patch

Environment

• WordPress: 6.5-RC1
• PHP: 8.0.30-dev
• Server: PHP.wasm
• Database: WP_SQLite_Translator (Server: 5.5 / Client: 3.40.1)
• Browser: Chrome 122.0.0.0
• OS: macOS
• Theme: Twenty Twenty-One 2.1
• MU Plugins:
  • 0-allow-wp-org.php
• Plugins:
  • SQLite Database Integration 2.1.6
  • Test Reports 1.1.0

Actual Results

1. ✅ Issue resolved with patch.

Additional Notes

• Tested this by uploading an invalid zip file. Renamed a different file as a zip file.

Supplemental Artifacts

[desrosj]

I made some very small adjustments, but this looks good. Thanks!

[desrosj]

In 57786:

Upload: Add links back to installer pages.

This adds a link back to the plugin or theme installers when an incompatible archive error message is encountered.

Props Presskopp, swissspidy, smub, pmbaldha, aneeshd16.
Fixes #60578.