WordPress.org
Get WordPress

Make WordPress Core

Opened 10 months ago

Last modified 9 months ago

#60593 new enhancement

Font Library: add terms and conditions

Reported by: mmaattiiaass's profile mmaattiiaass Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 6.5
Component: Editor Keywords: has-patch has-unit-tests
Focuses: Cc:

Description

What problem does this address?

  • Give users a way to accept or reject loading the data from a registered font collection.
  • Give font collection creators the ability to add a license text to inform users about the terms and conditions of the font collection.

What is your proposed solution?

  • Add terms and conditions field in the font collection.
  • Render the terms and conditions from a font collection in the frontend.
  • Make the Google fonts permission dialog font collection agnostic.

Change History (5)

This ticket was mentioned in ​PR #6152 on ​WordPress/wordpress-develop by ​@mmaattiiaass.
10 months ago #1

  • Keywords has-patch has-unit-tests added

## What?

Adds a terms_and_conditions property in the font collections.

## Why?
Trac ticket: https://core.trac.wordpress.org/ticket/60593

## Note:
Disclaimer: This PR includes the changes added in ​https://github.com/WordPress/wordpress-develop/pull/6130. That PR includes relevant changes so I started this branch from it for this PR. The commit history of this PR will be cleaned-up when #6130 is merged and the updated trunk is merged in this branch.

This ticket was mentioned in ​PR #6153 on ​WordPress/wordpress-develop by ​@mmaattiiaass.
10 months ago #2

What?

Adds a terms_and_conditions property in the font collections.
Why?

Trac ticket: https://core.trac.wordpress.org/ticket/60593
Note:

Disclaimer: This PR includes the changes added in ​https://github.com/WordPress/wordpress-develop/pull/6130. That PR includes relevant changes so I started this branch from it for this PR. The commit history of this PR will be cleaned-up when ​https://github.com/WordPress/wordpress-develop/pull/6130 is merged and the updated trunk is merged in this branch.

#3 @swissspidy
10 months ago

  • Component changed from General to Editor

Is this intended for 6.5 or 6.6?

Render the terms and conditions from a font collection in the frontend.
Make the Google fonts permission dialog font collection agnostic.

Is this work already in progress in Gutenberg? Basically whenever the TOS string is provided and not empty, GB would render a dialog with the permission dialog?

Do you have an example of such a TOS string? What if it needs to contain markup, like a link to some external website?

#4 @youknowriad
9 months ago

We already have this for google fonts but it's implemented in adhoc way, I think the idea of this ticket is to make this generic as an API for any registered font collection.

So for me it's an enhancement for the API that we can target for 6.6 or later.

#5 @youknowriad
9 months ago

  • Milestone changed from Awaiting Review to Future Release
Note: See TracTickets for help on using tickets.