Make WordPress Core

Opened 8 weeks ago

Last modified 3 weeks ago

#60632 new defect (bug)

The focus outline of the "Upload files" button is cut off

Reported by: wildworks's profile wildworks Owned by:
Milestone: 6.6 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch
Focuses: Cc:

Description

In the media library, when the "Media Library" tab is selected and the "Upload files" tab is focused, the right side of the outline is cut off.

Attachments (5)

media-library.png (8.0 KB) - added by wildworks 8 weeks ago.
"Media Library" tab is selected and "Upload files" tab is focused
patch.diff (365 bytes) - added by wildworks 8 weeks ago.
Patch to apply z-index to focused button to prevent cut-off
RTL.png (22.3 KB) - added by huzaifaalmesbah 8 weeks ago.
after apply patch
media-rtl.png (39.3 KB) - added by wildworks 8 weeks ago.
Media library in RTL language after applying patch
after applying patch-RTL.png (29.1 KB) - added by huzaifaalmesbah 8 weeks ago.
I'm testing again, now RTL work properly ✅

Download all attachments as: .zip

Change History (10)

@wildworks
8 weeks ago

"Media Library" tab is selected and "Upload files" tab is focused

@wildworks
8 weeks ago

Patch to apply z-index to focused button to prevent cut-off

#1 @wildworks
8 weeks ago

  • Keywords has-patch added

#2 @huzaifaalmesbah
8 weeks ago

Thank you for submitting the report, @wildworks. I've successfully reproduced the issue. After reviewing and testing your patch, I think we need fix for RTL in the patch.

@huzaifaalmesbah
8 weeks ago

after apply patch

#3 @wildworks
8 weeks ago

@huzaifaalmesbah Thank you for testing. In my environment, it is also fixed in RTL languages. My understanding is that if we build after applying the patch, it should also be reflected in the RTL stylesheet. What locale did you test it in?

@wildworks
8 weeks ago

Media library in RTL language after applying patch

@huzaifaalmesbah
8 weeks ago

I'm testing again, now RTL work properly ✅

This ticket was mentioned in Slack in #core-media by antpb. View the logs.


3 weeks ago

#5 @antpb
3 weeks ago

  • Milestone changed from Awaiting Review to 6.6

Moving this in to 6.6 so we can get this merged for the next release.

Note: See TracTickets for help on using tickets.