Opened 17 years ago
Closed 16 years ago
#6064 closed defect (bug) (fixed)
Gallery should not link to non-images as if they were images.
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 2.8 | Priority: | normal |
Severity: | normal | Version: | 2.5 |
Component: | Gallery | Keywords: | has-patch needs-testing |
Focuses: | Cc: |
Description
The gallery currently links to all files that it includes with the <img src="" />
tag. It should link not to the file, but to the icon that matches the file extension for non-image files.
Attachments (2)
Change History (9)
#3
@
17 years ago
The gallery should also present some way for a theme's css to show different styles for images and non-images.
#4
@
17 years ago
The [gallery] shortcode currently prints out a div inside a paragraph, along with a style tag.
The style tag should only be used inside the header, the div tag should not be used inside a p tag.
How this can be fixed
- div inside of p
- If a [gallery] tag is immediately next to the beginning or end of a paragraph, move the p tag to the other side of the gallery.
- If the [gallery] tag is the only thing in a paragraph, completely remove the p tag.
- style outside of head
- Have theme authors add the styles needed directly to their templates' stylesheets.
- Somehow move the style tag into the head tag. I don't think this is possible.
Note: See
TracTickets for help on using
tickets.
Never mind, disregard the attachment.