WordPress.org
Get WordPress

Make WordPress Core

Opened 11 months ago

Last modified 5 weeks ago

#60644 reopened enhancement

When theme installation fails, add a link to return to theme installer page

Reported by: pmbaldha's profile pmbaldha Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch
Focuses: Cc:

Description

When for any reason a theme installation fails (If the user uploads a zip file other than the theme zip file) you will be confronted with an error and there is no way out.
Screenshot: ​https://nimb.ws/OK9mRU1

Of course, you can use the browser's built-in back button, but still it would be nice to offer an additional link "Go to Theme Installer" (leading to wp-admin/theme-install.php)

Attachments (4)

iScreen Shoter - Google Chrome - 241121142251.jpg​ (111.7 KB) - added by karthickmurugan 2 months ago.
Go to Theme Installer Screenshot
60644.patch​ (1.0 KB) - added by karthickmurugan 2 months ago.
Patch file for adding "Go to Theme Installer" link if theme installation fails.
60644.2.patch​ (1.5 KB) - added by karthickmurugan 2 months ago.
Latest Patch file for adding "Go to Theme Installer" link if theme installation fails.
final.patch​ (1.6 KB) - added by karthickmurugan 2 months ago.
Final Patch file for adding "Go to Theme Installer" link if theme installation fails.

Download all attachments as: .zip

Change History (10)

#1 @swissspidy
11 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Heya, as noted on #60578 your existing PR there already does this. No need for an extra ticket that‘s essentially a duplicate.9

#2 @swissspidy
11 months ago

  • Keywords needs-patch added
  • Milestone set to Future Release
  • Resolution duplicate deleted
  • Status changed from closed to reopened

@karthickmurugan
2 months ago

Go to Theme Installer Screenshot

@karthickmurugan
2 months ago

Patch file for adding "Go to Theme Installer" link if theme installation fails.

#3 @karthickmurugan
2 months ago

@pmbaldha - Fixed the issue by adding "Go to Theme Installer" link when the theme installation fails. I have attached the screenshot and the latest patch file (final.patch).

cc - @swissspidy

Last edited 2 months ago by karthickmurugan (previous) (diff)

#4 @karthickmurugan
2 months ago

  • Keywords has-patch added; needs-patch removed

@karthickmurugan
2 months ago

Latest Patch file for adding "Go to Theme Installer" link if theme installation fails.

@karthickmurugan
2 months ago

Final Patch file for adding "Go to Theme Installer" link if theme installation fails.

#5 @karthickmurugan
6 weeks ago

@swissspidy - Can you please take a look at the final.patch file. Thanks in advance.

#6 @ankitkumarshah
5 weeks ago

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/60644/final.patch

Environment

  • WordPress: 6.8-alpha-59506
  • PHP: 8.1.29
  • Server: nginx/1.16.0
  • Database: mysqli (Server: 8.0.16 / Client: mysqlnd 8.1.29)
  • Browser: Chrome 131.0.0.0
  • OS: macOS
  • Theme: Twenty Fifteen 3.9
  • MU Plugins: None activated

Actual Results

  1. ✅ Issue resolved with patch.

Additional Notes

Hi @pmbaldha,
I believe this is a valuable improvement to the user experience. I have tested the patch provided by @karthickmurugan (https://core.trac.wordpress.org/attachment/ticket/60644/final.patch), and it resolves the issue.

For reference, I have also included the screencast below to showcase the fix in action.

Supplemental Artifacts

​https://utfs.io/f/TnWMEUzoUd85NlZzaZRQlpDsFZMeHW21jnYBKOUtIxyibgfh

Note: See TracTickets for help on using tickets.