Make WordPress Core

Opened 3 months ago

Closed 7 weeks ago

#60648 closed task (blessed) (fixed)

Update the `$_old_files` array for 6.5

Reported by: swissspidy's profile swissspidy Owned by: swissspidy's profile swissspidy
Milestone: 6.5 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: has-patch fixed-major dev-reviewed
Focuses: Cc:

Description (last modified by swissspidy)

Updating from 6.4 to 6.5 Beta 3 results in the following files being removed:

File removed: wp-includes/ID3/license.commercial.txt
File removed: wp-includes/blocks/query/style-rtl.min.css
File removed: wp-includes/blocks/query/style.min.css
File removed: wp-includes/blocks/query/style-rtl.css
File removed: wp-includes/blocks/query/style.css
File removed: wp-admin/images/about-header-privacy.svg
File removed: wp-admin/images/about-header-about.svg
File removed: wp-admin/images/about-header-credits.svg
File removed: wp-admin/images/about-header-freedoms.svg
File removed: wp-admin/images/about-header-contribute.svg
File removed: wp-admin/images/about-header-background.svg

See also https://make.wordpress.org/core/handbook/about/release-cycle/releasing-major-versions/#dry-run

While there is an initial patch already, please double check before committing.

Attachments (1)

Huzaifa-20240227224633.png (651.7 KB) - added by huzaifaalmesbah 3 months ago.
I'm noticing it too

Download all attachments as: .zip

Change History (23)

This ticket was mentioned in PR #6192 on WordPress/wordpress-develop by @swissspidy.


3 months ago
#1

  • Keywords has-patch added; needs-patch removed

#2 @swissspidy
3 months ago

  • Description modified (diff)

#3 @davidbaumwald
3 months ago

Just noting that the list will probably change when we run the svn diff commands during the Dry Run. A commit for $_old_files is typically one of the very last things we do before the 24-hour freeze starts.

@huzaifaalmesbah
3 months ago

I'm noticing it too

#4 @swissspidy
3 months ago

Yup I mentioned it in the description.

#5 @swissspidy
3 months ago

  • Owner set to swissspidy
  • Status changed from assigned to accepted

#6 @swissspidy
3 months ago

Deleted files as of 6.5 RC 1 (unchanged since the ticket was opened):

$ svn diff --summarize https://core.svn.wordpress.org/tags/6.4.3 https://core.svn.wordpress.org/branches/6.5 | grep '^D'
D       https://core.svn.wordpress.org/tags/6.4.3/wp-admin/images/about-header-freedoms.svg
D       https://core.svn.wordpress.org/tags/6.4.3/wp-admin/images/about-header-contribute.svg
D       https://core.svn.wordpress.org/tags/6.4.3/wp-admin/images/about-header-about.svg
D       https://core.svn.wordpress.org/tags/6.4.3/wp-admin/images/about-header-credits.svg
D       https://core.svn.wordpress.org/tags/6.4.3/wp-admin/images/about-header-privacy.svg
D       https://core.svn.wordpress.org/tags/6.4.3/wp-admin/images/about-header-background.svg
D       https://core.svn.wordpress.org/tags/6.4.3/wp-includes/ID3/license.commercial.txt
D       https://core.svn.wordpress.org/tags/6.4.3/wp-includes/blocks/query/style-rtl.min.css
D       https://core.svn.wordpress.org/tags/6.4.3/wp-includes/blocks/query/style.css
D       https://core.svn.wordpress.org/tags/6.4.3/wp-includes/blocks/query/style.min.css
D       https://core.svn.wordpress.org/tags/6.4.3/wp-includes/blocks/query/style-rtl.css
Version 0, edited 3 months ago by swissspidy (next)

This ticket was mentioned in Slack in #core by swissspidy. View the logs.


2 months ago

This ticket was mentioned in Slack in #core by desrosj. View the logs.


2 months ago

#9 @audrasjb
7 weeks ago

  • Keywords commit added

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


7 weeks ago

#11 @audrasjb
7 weeks ago

Removing commit as per today's dry run

#12 @audrasjb
7 weeks ago

  • Keywords commit removed

#13 @davidbaumwald
7 weeks ago

OK, so before I commit this, I also ran the check for added files, and it seems these files were added back in for 6.5, but they were previously included in 5.9.

'wp-includes/blocks/post-content/editor.css',
'wp-includes/blocks/post-content/editor.min.css',
'wp-includes/blocks/post-content/editor-rtl.css',
'wp-includes/blocks/post-content/editor-rtl.min.css',

Can I get a double check before I commit this?

#14 @davidbaumwald
7 weeks ago

  • Component changed from General to Upgrade/Install
  • Keywords commit added

Disregard my previous comment. Current patch is complete and accurate. Working on merging to trunk now.

#15 @audrasjb
7 weeks ago

  • Keywords commit removed

Just noting I double checked the above with David during the dry run.
Re-marking this for commit consideration.

#16 @audrasjb
7 weeks ago

  • Keywords commit added

#17 @davidbaumwald
7 weeks ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 57905:

Upgrade/Install: Update the $_old_files array for 6.5.

Props audrasjb, huzaifaalmesbah, swissspidy.
Fixes #60648.

#18 @davidbaumwald
7 weeks ago

  • Keywords dev-feedback added; commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport to the 6.5 branch.

#19 @audrasjb
7 weeks ago

  • Keywords fixed-major dev-reviewed added; dev-feedback removed

Marking as dev reviewed and ready for backport.

#20 @davidbaumwald
7 weeks ago

In 57906:

Upgrade/Install: Update the $_old_files array for 6.5.

Reviewed by audrasjb.
Merges [57905] to the 6.5 branch.

Props audrasjb, huzaifaalmesbah, swissspidy.
See #60648.

#22 @audrasjb
7 weeks ago

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.