sanitize_locale_name() should reject non-strings

[dd32]

While debugging some locale-related oddities, I ran into sanitize_locale_name() happily accepting arrays.

wp> sanitize_locale_name( [ 'test@test' => 'test@test' ] );

array(1) {
  'test@test' =>
  string(8) "testtest"
}

This is not uncommon for WordPress functions that rely upon preg_replace() and a number of other sanitize functions behave similarly.

I would expect an array input to return either '' as array( .. ) is not a valid string.

[swissspidy]

Returning an empty string if the input is not a string souvds reasonable. However, note that the docblock says the function expects a string.

[ocean90]

Replying to dd32:

and a number of other sanitize functions behave similarly.

It seems like only sanitize_key() has a check for is_scalar()? I guess if sanitize_locale_name() needs to be updated we should make all sanitize functions consistent in this way.

[swissspidy]

Revisiting this, I don't see a need to change just this function specifically.