Changes between Initial Version and Version 1 of Ticket #60652, comment 33
- Timestamp:
- 03/24/2024 07:54:01 PM (20 months ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #60652, comment 33
initial v1 1 1 Think the inline docs/docblocks need fixing after [57868]. For example: it introduces a private function `_wp_filter_font_directory()` but the docs have "recommended usage" section? As far as I'm aware it is not recommended for plugins and themes to use any of the WP functions marked as private. 2 2 3 In addition thinking there should be a warning that the above function will be removed in WP 6.6 (as discussed in the PR) as the implementation there will be revised. It is pretty unfortunate that [57868] exposes this function (it was a lambda function "hidden" in `handle_font_file_upload()` before), but thinking that at least the extenders can be warned not to use it as it will go away in 6.6.3 In addition thinking there should be a warning that the above function will be removed in WP 6.6 (as [https://github.com/WordPress/wordpress-develop/pull/6211 discussed in the PR]) as the implementation there will be revised. It is pretty unfortunate that [57868] exposes this function (it was a lambda function "hidden" in `handle_font_file_upload()` before), but thinking that at least the extenders can be warned not to use it as it will go away in 6.6.