WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#60665 closed defect (bug) (fixed)

Backport changes from pattern overrides id -> name change

Reported by: talldanwp's profile talldanwp Owned by: talldanwp's profile talldanwp
Milestone: 6.5 Priority: normal
Severity: normal Version: 6.5
Component: Editor Keywords: has-patch 2nd-opinion
Focuses: Cc:

Description

Some changes were made to the pattern overrides feature in the Gutenberg project in this pull request - ​Use block naming for marking blocks as overridable in patterns.

This ticket tracks backporting the changes to core (which I'll work on).

Change History (5)

This ticket was mentioned in ​PR #6208 on ​WordPress/wordpress-develop by ​@talldanwp.
2 years ago #1

  • Keywords has-patch added

Backports the PHP changes from ​https://github.com/WordPress/gutenberg/pull/59268

Trac ticket: https://core.trac.wordpress.org/ticket/60665

​@youknowriad commented on ​PR #6208:
2 years ago #2

We should wait for the package update to commit this.

#3 @swissspidy
2 years ago

  • Keywords 2nd-opinion added

This appears to be pending a discussion on the Gutenberg side: ​https://github.com/WordPress/gutenberg/issues/53705

Adding 2nd-opinion as a way to track this.

​@youknowriad commented on ​PR #6208:
2 years ago #4

I'm going to include this one in #6218 because it needs to land at the same time.

#5 @youknowriad
2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 57760:

Editor: Update Packages with the latest bug fixes for 6.5 RC 1

It includes all the backports from this Gutenberg PR ​https://github.com/WordPress/gutenberg/pull/59541/

Props get_dave, youknowriad, talldanwp.
See #60315.
Fixes #60665.

Note: See TracTickets for help on using tickets.