Unwanted section appears as a sidebar in 'Create gallery' section

[ukdrahul]

Unwanted section with 'Actions' and 'Create gallery' texts appear in the sidebar of Media Library and nothing happens on selection or click of the texts.

To find the issue, please go through the below steps.

1.From the 'File' block add the block 'Gallery', then select Media Library.
2.Unwanted sidebar section with the specified texts appears.

[ukdrahul]

Unwanted sidebar appears for gallery block

[ababir]

I have seen the same issue for just the image block. Here is ticket #58973. It seems like this ticket was solved on 6.5. But it still exists for the 'Image Gallery' block.

[joedolson]

It's appearing because it's showing the context of the gallery creation, but it is rather pointless, since it's the only option available. It doesn't do anything because there are no alternatives available.

Setting the version to 5.0 for now, I'm guessing this has existed since galleries showed up in the block editor, but I'll have to research that later.

[ruchirj]

Hello i just change the code and it's working for all block who have no action menu here is below,

before changes:

	_menu: function() {
		var menu = this.frame.menu,
			mode = this.get('menu'),
			actionMenuItems,
			actionMenuLength,
			view;

		if ( this.frame.menu ) {
			actionMenuItems = this.frame.menu.get('views'),
			actionMenuLength = actionMenuItems ? actionMenuItems.views.get().length : 0,
			// Show action menu only if it is active and has more than one default element.
			this.frame.$el.toggleClass( 'hide-menu', ! mode || actionMenuLength < 2 );
		}
		if ( ! mode ) {
			return;
		}

		menu.mode( mode );

		view = menu.get();
		if ( view && view.select ) {
			view.select( this.id );
		}
	},

and after changes :

	_menu: function() {
		var menu = this.frame.menu,
			mode = this.get('menu'),
			actionMenuItems,
			actionMenuLength,
			view,
            actionMenuItems = this.frame.menu.get('views'),
			actionMenuLength = actionMenuItems ? actionMenuItems.views.get().length : 0;

		if ( this.frame.menu ) {
			// Show action menu only if it is active and has more than one default element.
			this.frame.$el.toggleClass( 'hide-menu', ! mode || actionMenuLength < 2 );
		}
		if ( ! mode || actionMenuLength < 2) {
			return;
		}

		menu.mode( mode );

		view = menu.get();
		if ( view && view.select ) {
			view.select( this.id );
		}
	},

media-view.js
line 2282 to 2305.

[ruchirj]

hello all any one look at this please.

[nhrrob]

We have reviewed this in today's bug scrub.
Changes requested doesn't seem a valid keyword here.

Also a possible fix is given in https://core.trac.wordpress.org/ticket/60666#comment:4

Anyone wants to add a patch or PR?

[joedolson]

Converts comment into patch

Trac ticket: https://core.trac.wordpress.org/ticket/60666

[joedolson]

I'm not sure this patch works as described; at least, not as far as I can tell. However, the original testing instructions also don't entirely make sense to me: I'm not sure what "From the 'File' block add the block 'Gallery', then select Media Library." means.

@ukdrahul Are you able to clarify the instructions for reproducing the issue? I'm not clear what the File block has to do with this.

[shailu25]

Here are the steps to reproduce the issue:

• Create a new post/page.
• Select the Gallery block and click on the Media Library option.
• You will notice that the unwanted section appears in sidebar.
• Added Attachment for Reference.

[shailu25]

Added Attchment

[shailu25]

Related: 58973

[oglekler]

We have RC1 and patch needs at least testing, so, I am moving it to the next milestone.

[rsiddiqe]

Replying to joedolson:

Hey, trying to implement the patch (60666.diff) on a fresh install of 6.5 and 5.5. Can't find the file to patch (state.js) within the installation directory.

The given path is src/js/media/controllers/state.js . However searching for 'state.js' within the WordPress installation directory finds no such file.

Am I doing something wrong here?

[sudipatel007]

Test Report

Description
I have added patch in my local and it is working fine - https://core.trac.wordpress.org/attachment/ticket/60666/60666.diff

Environment

• WordPress: 6.6-RC1-58573
• PHP: 8.1.23
• Server: nginx/1.16.0
• Database: mysqli (Server: 8.0.16 / Client: mysqlnd 8.1.23)
• Browser: Chrome 126.0.0.0 (macOS)
• Theme: Twenty Nineteen 2.8

Results
Before Patch
​https://prnt.sc/PyELnbnvbjLe

After Patch
Screenshot - ​https://prnt.sc/5KT-Vx2Tch_l
Video - ​https://www.loom.com/share/71aacf85758543c386440e45254563d1?sid=6997c9ed-e284-4a97-bc4d-2042e994303e

[ukdrahul]

@joedolson As the testing went well (done by @sudipatel007 ), I was wondering if we could try to resolve this minor bug in version 6.6 and finalize it. Would that be possible?

[joedolson]

@rsiddiqe You need to apply patches to the WordPress src directory; if you don't have a state.js file, then you're looking at a copy of WordPress that's already been built.

@ukdrahul No, now that we're in the release candidate phase nothing can be committed that isn't an issue introduced during the 6.6 cycle.

[dhrumilk]

Test Report

Description

I have applied the https://core.trac.wordpress.org/attachment/ticket/60666/60666.diff patch locally, and it is functioning as expected.

Environment

WordPress: 6.6
PHP: 8.2.12
Server: apache
Browser: Chrome 129.0.6668.58
Theme: Twenty Twenty

Results

The patch is working as expected.

[sudipatel007]

Test Report

Description

I have added patch in my local and it is working fine - https://core.trac.wordpress.org/attachment/ticket/60666/60666.diff

Environment

• WordPress: 6.7-alpha-59086
• PHP: 8.2.23
• Server: Apache/2.4.62 (Debian)
• Database: mysqli (Server: 11.5.2-MariaDB-ubu2404 / Client: mysqlnd 8.2.23)
• Browser: Chrome 129.0.0.0 (macOS)
• Theme: Twenty Twenty-Four 1.2
• MU-Plugins: None activated
• Plugins:
  • WordPress Beta Tester 3.5.6

Results

Before Patch
​https://prnt.sc/Tgsj29KObflW

After Patch
​https://prnt.sc/mHoytwiCmvwu

[joedolson]

In 59139:

Media: Hide sidebar in Create Gallery when no actions available.

Check whether the media frame menu has action items. If not, hide the sidebar. Prevents showing a sidebar that looks interactive but contains no controls that are interactive. When in Create Gallery mode, the only action available is 'Create Gallery', and it is always active.

Props ukdrahul, ababir, ruchirj, nhrrob, joedolson, shailu25, mukesh27, sudipatel007, dhrumilk.
Fixes #60666.

In r59139

[peterwilsoncc]

The tests in the Gutenberg repo have picked up an error with this as the left sidebar is no longer displayed when inserting media within the classic block.

See ​https://github.com/WordPress/gutenberg/actions/runs/11116072767/job/30885672515

Reopening for follow-up.

[ramonopoly]

The tests in the Gutenberg repo have picked up an error with this as the left sidebar is no longer displayed when inserting media within the classic block.

Can confirm. Not sure what the fix is. Is it possible from within the media controller to know if it's been activated by a classic block?

[joedolson]

Yeah, this has over-reached, and it's impacting cases beyond what it should. May need to revert; but I'll explore further tomorrow.

[desrosj]

Came here because I noticed a seemingly related problem in the media library itself. Clicking on attachments in gallery view has no effect. I tried the commit prior to this change and everything seemed to work great.

[joedolson]

I'm going to revert this; while it is doing what it says it'll do, it's *also* doing a lot of other things.

I haven't been able to reproduce what you're describing, though @desrosj. Can you be specific about what environment you're using?

[joedolson]

In 59156:

Revert [59139] due to broad side effects in media library.

The change in [59139] caused all media modal menus to disappear.

Unprops joedolson.
See #60666.

[desrosj]

I am using the local Docker environment. But I'm also seeing it on my personal site with beta 1 installed.

[audrasjb]

As per today's bug scrub: The ticket wasn't updated in 4 months, so I'm going to move it to Future Release. When a patch is ready to go, feel free to reassign it in a milestone.

Trac ticket: https://core.trac.wordpress.org/ticket/60666

[sukhendu2002]

I opened PR for this ticket: ​https://github.com/WordPress/wordpress-develop/pull/12122

The previous fix in r59139 was reverted because it returned early from _menu() and prevented menu rendering in other media modal flows, including the Classic block flow.

This PR keeps the menu rendering lifecycle intact, then hides the menu only when the rendered menu has fewer than two visible actionable items. This removes the redundant Actions / Create Gallery menu in the Gallery block media modal without skipping menu setup for other flows.

Any review would be appreciated.