Make WordPress Core

Opened 3 months ago

Closed 2 months ago

#60667 closed defect (bug) (wontfix)

Twenty Seventeen: Cover block font-size does not apply to headings

Reported by: nidhidhandhukiya's profile nidhidhandhukiya Owned by:
Milestone: Priority: normal
Severity: normal Version: 6.4.3
Component: Bundled Theme Keywords: close 2nd-opinion
Focuses: Cc:

Description

Steps to reproduce the issue :-

  1. Activate Twenty Seventeen theme.
  2. Choose Cover Block.
  3. Add Paragraph and Heading block inside cover block.
  4. Now give font-size from cover block settings.

You can able to see that whatever font-size is choosen directly from the Cover block that is not applied on Heading block.
I have attached video for better understanding.
Video URL :- https://share.cleanshot.com/dqrXphrT236ZJ5xP0mFh

Attachments (1)

60667.patch (1.6 KB) - added by nidhidhandhukiya 3 months ago.

Download all attachments as: .zip

Change History (3)

#1 @sabernhardt
3 months ago

  • Keywords close 2nd-opinion added
  • Summary changed from Twenty Seventeen - Cover block is having issue when font-size is choosen. to Twenty Seventeen: Cover block font-size does not apply to headings

Headings should not automatically inherit font sizes from the Cover block. Then those would have the same size as a paragraph without its own font size, as well as any headings of a different semantic level. And while creating a relative scale for headings in a Cover block might have been nice before anyone used those special options, it's too late for that now.

You can set the font size directly on a Heading or Paragraph block within a Cover block.

#2 @karmatosed
2 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Thank you everyone for your collaboration on this. I agree with @sabernhardt that for now closing this makes sense. We can always consider approaches within the cover block, but this isn't something to change today in the theme itself.

Note: See TracTickets for help on using tickets.