Make WordPress Core

Opened 5 months ago

Closed 8 days ago

Last modified 8 days ago

#60669 closed defect (bug) (fixed)

Twenty Twenty-Two: Search block does not show selected border on button

Reported by: viralsampat's profile viralsampat Owned by: karmatosed's profile karmatosed
Milestone: 6.7 Priority: normal
Severity: normal Version: 6.4.3
Component: Bundled Theme Keywords: has-patch commit
Focuses: css Cc:

Description

Hello,

I have reviewed and found that the "Search Block" border does not appear in front end.

Here, I have attached its screenshots.

Environment info

Device: Macbook M1
OS: 14.3.1 (23D60)
Browser: Google Chrome
Version 121.0.6167.184 (Official Build) (arm64)
WordPress version: 6.5-beta2 running, Gutenberg 17.8.0, Theme active: Twenty-Twenty-Two.

Thanks,

Attachments (5)

CleanShot 2024-03-01 at 15.59.20@2x.png (206.8 KB) - added by viralsampat 5 months ago.
Back-end
CleanShot 2024-03-01 at 15.58.52@2x.png (123.2 KB) - added by viralsampat 5 months ago.
Front-end
60669.patch (557 bytes) - added by viralsampat 5 months ago.
I have checked above mentioned issue and I have added its patch.
60669.1.patch (582 bytes) - added by sabernhardt 2 weeks ago.
replaces border: none with border: 0 solid
SCR-20240715-scpx.png (37.0 KB) - added by karmatosed 8 days ago.

Download all attachments as: .zip

Change History (13)

#1 @poena
5 months ago

  • Component changed from General to Bundled Theme
  • Summary changed from Twenty-Twenty-Two: The border of the search block does not appear in the search button. to Twenty-Twenty-Two: The search block does not look the same same in the editor and the front.

It is more than the border, the theme is missing default for the search block in the editor.
It should match the default styles that are used on the front.

@viralsampat
5 months ago

I have checked above mentioned issue and I have added its patch.

#2 @sabernhardt
8 weeks ago

#61310 was marked as a duplicate.

@sabernhardt
2 weeks ago

replaces border: none with border: 0 solid

#3 @sabernhardt
2 weeks ago

  • Focuses ui removed
  • Keywords has-patch needs-testing added; dev-feedback removed
  • Milestone changed from Awaiting Review to Future Release
  • Summary changed from Twenty-Twenty-Two: The search block does not look the same same in the editor and the front. to Twenty Twenty-Two: Search block does not show selected border on button

#4 @karmatosed
8 days ago

I am going to test this and see about progressing it thank you everyone for the collaboration.

#5 @karmatosed
8 days ago

  • Keywords commit added

This looks ready to commit to me in testing. Attaching a screenshot of what I see now and going to move this to commit. Thank you everyone.

#6 @karmatosed
8 days ago

  • Owner set to karmatosed
  • Resolution set to fixed
  • Status changed from new to closed

In 58727:

Twenty Twenty-Two: Fixes search block not showing selected border on bottom.

The border was not showing on search block. This brings in a resolution for that removing the none from border property.

Props viralsampat, poena, sabernhardt.
Fixes #60669.

#7 @karmatosed
8 days ago

  • Milestone changed from Future Release to 6.7

#8 @karmatosed
8 days ago

  • Keywords needs-testing removed
Note: See TracTickets for help on using tickets.