Make WordPress Core

Opened 7 weeks ago

Closed 7 weeks ago

#60676 closed enhancement (invalid)

password-strength-meter.js: deprecated message and translation hints visible in generated source code

Reported by: inno1's profile inno1 Owned by:
Milestone: Priority: normal
Severity: normal Version: 6.4.3
Component: Script Loader Keywords:
Focuses: javascript Cc:

Description (last modified by sabernhardt)

WordPress 6.4.3
Looking in the HTML source code in the page "forgotten password" I found the following lines, including a "deprecated" message and hints for translating:

<script id="password-strength-meter-js-translations">
( function( domain, translations ) {
	var localeData = translations.locale_data[ domain ] || translations.locale_data.messages;
	localeData[""].domain = domain;
	wp.i18n.setLocaleData( localeData, domain );
} )( "default", {"translation-revision-date":"2024-01-30 16:22:31+0000","generator":"GlotPress\/4.0.0-beta.2","domain":"messages","locale_data":{"messages":{"":{"domain":"messages","plural-forms":"nplurals=2; plural=n != 1;","lang":"de"},"%1$s is deprecated since version %2$s! Use %3$s instead. Please consider writing more inclusive code.":["%1$s ist seit Version %2$s veraltet! Benutze stattdessen %3$s. Bitte erw\u00e4ge, inklusiveren Code zu schreiben."]}},"comment":{"reference":"wp-admin\/js\/password-strength-meter.js"}} );
</script>

Change History (3)

#1 @sabernhardt
7 weeks ago

  • Description modified (diff)

#2 @sabernhardt
7 weeks ago

  • Keywords needs-patch removed

Hi and welcome to WordPress Core Trac!

I think you have a plugin that calls the deprecated wp.passwordStrength.userInputBlacklist() (see #50413). It might be one of these 43 plugins, if you want to report it in their support forum.

Last edited 7 weeks ago by sabernhardt (previous) (diff)

#3 @swissspidy
7 weeks ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

It sounds more like you are reporting the mere existence of this string in the source code.

That's not an issue, but expected, because there is such a deprecation string in the JavaScript file, see https://github.com/WordPress/wordpress-develop/blob/ee5142efbca11450e7befd202d37eba4660173c1/src/js/_enqueues/wp/password-strength-meter.js#L63-L71

And this text can be translated, which is why you see that there.

Note: See TracTickets for help on using tickets.