WordPress.org
Get WordPress

Make WordPress Core

Opened 7 months ago

Closed 6 months ago

Last modified 6 months ago

#60677 closed defect (bug) (fixed)

Docs: Add missing @global tag and adjust tag position

Reported by: wildworks's profile wildworks Owned by: audrasjb's profile audrasjb
Milestone: 6.5 Priority: normal
Severity: normal Version: 6.5
Component: General Keywords: commit has-patch
Focuses: docs Cc:

Description

This is also a backport of the updated code in the Gutenberg repository: ​https://github.com/WordPress/gutenberg/pull/59522

  • In the wp_interactivity() function, the @global tag is placed before the @since tag
  • $wp_query global variable is used inside render_block_core_post_template() function but @global tag is missing

Attachments (1)

60677.patch​ (1.3 KB) - added by wildworks 7 months ago.

Download all attachments as: .zip

Change History (7)

@wildworks
7 months ago

#1 @audrasjb
7 months ago

  • Keywords commit has-patch added
  • Milestone changed from Awaiting Review to 6.5
  • Owner set to audrasjb
  • Status changed from new to assigned
  • Version set to trunk

Thanks for the patch.

Introduced in [57563].
Moving to 6.5 and self assigning for commit.

#2 @audrasjb
7 months ago

  • Focuses docs added

#3 @audrasjb
6 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 57774:

Docs: Add missing @global mention in wp_interactivity().

This merges a changeset updated upstream in the Gutenberg repository.
See ​https://github.com/WordPress/gutenberg/pull/59522.

Props wildworks.
Fixes #60677.
See #59651.

#4 @audrasjb
6 months ago

In 57775:

Partially revert [57774].

This reverts some changes that need to be properly synced from Gutenberg.

See #60677.

#5 @audrasjb
6 months ago

@wildworks thanks for the patch. However please note that I had to partially revert this changeset, since it was touching a file located in wp-includes/blocs/, which need to be modified via a Gutenberg packages synchronization, and not within a Trac patch.

#6 @wildworks
6 months ago

Sorry for the inconvenience. I should have known that file changes in the blocks directory would be synced as part of the Gutenberg package, but I had overlooked that. I will be careful in the future.

Note: See TracTickets for help on using tickets.