#60681 closed defect (bug) (fixed)
Elements: Fix application of element class name when attributes are filtered
Reported by: | aaronrobertshaw | Owned by: | isabel_brison |
---|---|---|---|
Milestone: | 6.6 | Priority: | normal |
Severity: | normal | Version: | 6.5 |
Component: | Editor | Keywords: | gutenberg-merge has-patch has-unit-tests |
Focuses: | Cc: |
Description
This ticket tracks the backporting of PHP files for the following Gutenberg changes:
These changes fix a bug where if the block data was filtered via render_block_data
the elements CSS class wouldn't be consistently applied breaking the feature.
The initial solution that was merged in Gutenberg via https://github.com/WordPress/gutenberg/pull/59533 caused a conflict in CSS classes that https://github.com/WordPress/gutenberg/pull/59535 addresses.
Change History (8)
This ticket was mentioned in PR #6214 on WordPress/wordpress-develop by @aaronrobertshaw.
7 months ago
#1
- Keywords has-patch has-unit-tests added
@aaronrobertshaw commented on PR #6214:
7 months ago
#2
This PR is still only in a draft state as I have run out of time. Unfortunately, I'll be AFK until next week with limited bandwidth to push this across the line.
Anyone is welcome to pick this up, push to it, or create an alternate PR 🙏
#3
@
6 months ago
- Milestone changed from Awaiting Review to 6.6
Based on https://github.com/WordPress/gutenberg/pull/59535#issuecomment-1992881732 I am moving this to 6.6
@aaronrobertshaw commented on PR #6214:
5 months ago
#4
Thanks for the review @tellthemachines 👍
I've addressed the feedback https://github.com/WordPress/wordpress-develop/pull/6214/commits/1789ecf5fd659aa1da57c165cfc0086720c6e185 & https://github.com/WordPress/wordpress-develop/pull/6214/commits/8e60ca74fd4098e484488757b154e8e877610615.
#5
@
5 months ago
- Owner set to isabel_brison
- Resolution set to fixed
- Status changed from new to closed
In 58074:
@isabel_brison commented on PR #6214:
5 months ago
#6
Committed in r58074.
@aaronrobertshaw commented on PR #6214:
5 months ago
#7
@mukeshpanchal27 as these changes were already committed, I've created a follow-up PR to address the issues noted
Syncs the changes from https://github.com/WordPress/gutenberg/pull/59535.
These change update the elements block support filters such that the elements class name is only generated in a single location. This avoids conflicts between class names and makes the block support robust in the face of a block's data being filtered via other
render_block_data
filters.To test:
Confirm https://github.com/WordPress/gutenberg/issues/59462 is still resolved
Create some nested blocks containing links
Unit tests:
Trac ticket: https://core.trac.wordpress.org/ticket/60681