Make WordPress Core

Opened 11 months ago

Closed 11 months ago

Last modified 11 months ago

#60686 closed defect (bug) (fixed)

Improve the descriptive text that's used for the site icon

Reported by: johnbillion's profile johnbillion Owned by: jorbin's profile jorbin
Milestone: 6.5 Priority: normal
Severity: normal Version: 6.5
Component: General Keywords: has-patch
Focuses: Cc:

Description

The descriptive text that's used for the site icon control added in #54370 unnecessarily refers to site icons in the plural. Let's fix the phrasing.

Change History (6)

This ticket was mentioned in PR #6223 on WordPress/wordpress-develop by @johnbillion.


11 months ago
#1

  • Keywords has-patch added

#2 @jorbin
11 months ago

The plural was what was used as of [41749] based on #40430 so this dates much farther back than #54370.

#3 @jorbin
11 months ago

My preference is to keep the plural as I think it reads easier and is what has been in place for 6+ years, but I also don't feel strongly enough to object if it's something others belive strongly in. I do think it's important to keep the capitalization though and have suggested that on the PR.

#4 @audrasjb
11 months ago

The singular form makes more sense to me.
But concerning the capitalisation what we need is to keep consistency with other strings (capitalisation is used elsewhere like in the Change Site Icon / Choose Site Icon button in option-general.php). And on the other side, we are not very consistent right now since we have a Select site icon string in customize/class-wp-customize-media-control.php… 🙃

#5 @jorbin
11 months ago

  • Owner set to jorbin
  • Resolution set to fixed
  • Status changed from new to closed

In 57766:

UI-Copy: Use capital cased singular for Site Icon.

Follow up to [41749], [57713], and [57730].

Props johnbillion, audrasjb.
Fixes #60686.

Note: See TracTickets for help on using tickets.