WordPress.org
Get WordPress

Make WordPress Core

Opened 14 months ago

Closed 14 months ago

Last modified 9 months ago

#60712 closed defect (bug) (fixed)

Typo correction in `tests/phpunit/data/themedir1/fonts-block-theme/styles/variation-new-font-family.json`

Reported by: audrasjb's profile audrasjb Owned by: swissspidy's profile swissspidy
Milestone: 6.6 Priority: normal
Severity: normal Version: 6.4
Component: Build/Test Tools Keywords: good-first-bug has-patch has-unit-tests commit
Focuses: Cc:

Description

While looking at #60711 I spotted a small typo in tests/phpunit/data/themedir1/fonts-block-theme/styles/variation-new-font-family.json:

file:./assets/fonts/open-sans/OpenSans-VariableFont_wdth,wght.tff
Should be replaced with:
file:./assets/fonts/open-sans/OpenSans-VariableFont_wdth,wght.ttf

Introduced in [56500].

Change History (11)

#1 @audrasjb
14 months ago

  • Milestone changed from Awaiting Review to 6.5
  • Version set to 6.4

Moving to 6.5 as it is only a unit test fix.

This ticket was mentioned in ​PR #6229 on ​WordPress/wordpress-develop by ​@huzaifaalmesbah.
14 months ago #2

  • Keywords has-patch has-unit-tests added; needs-patch removed

I replace tff to ttf

#3 @mukesh27
14 months ago

  • Keywords commit added

The ​PR #6229 looks good and ready for commit.

#4 @swissspidy
14 months ago

  • Owner set to swissspidy
  • Status changed from new to reviewing

#5 @swissspidy
14 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 57788:

Build/Test Tools: Fix typo in variation-new-font-family.json fixture file.

Props huzaifaalmesbah, mukesh27.
Fixes #60712.

#6 @kebbet
14 months ago

This ticket is fixed in trunk, not in 6.5. Either re-open for 6.5 backport or change milestone to 6.6?

#7 @audrasjb
14 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Thanks for the patch @huzaifaalmesbah. However please note that tickets with good-first-bug workflow keyword are supposed to be kept for new contributors so they can learn how to make their very first patch to WP Core.

Reopening for backport.

#8 @huzaifaalmesbah
14 months ago

Thank you for your feedback, @audrasjb. Your point has been duly noted.

#9 @swissspidy
14 months ago

  • Keywords fixed-major removed
  • Milestone changed from 6.5 to 6.6
  • Resolution set to fixed
  • Status changed from reopened to closed

This is just a tests file, no need to backport anything.

#11 @swissspidy
14 months ago

  • Resolution set to fixed

​@SergeyBiryukov commented on ​PR #6229:
9 months ago #12

Thanks for the PR! This was merged in r57788.

Note: See TracTickets for help on using tickets.