#60719 closed enhancement (fixed)
Add fonts upload location to Site Health report
Reported by: | swissspidy | Owned by: | audrasjb |
---|---|---|---|
Milestone: | 6.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Site Health | Keywords: | good-first-bug has-patch has-screenshots has-testing-info |
Focuses: | Cc: |
Description
Just like Site Health lists the paths to the plugins/themes/uploads directories, we should list the path to the fonts directory (and its size) there as well.
Attachments (9)
Change History (38)
This ticket was mentioned in PR #6260 on WordPress/wordpress-develop by @andr3ribeiro.
8 months ago
#2
- Keywords has-patch added; needs-patch removed
Added the font directory in the array for site health table iteration
This ticket was mentioned in Slack in #core-test by krupajnanda. View the logs.
8 months ago
#4
@
8 months ago
- Keywords has-screenshots has-testing-info added
I tested changes with mentioned GH PR and it shows the font dir path and size to Site Health.
Test Report
Description
This report validates whether the indicated patch works as expected.
PR tested: https://github.com/WordPress/wordpress-develop/pull/6260
Environment
- WordPress: 6.6-alpha-57778-src
- PHP: 8.2.15
- Server: nginx/1.25.3
- Database: mysqli (Server: 8.0.36 / Client: mysqlnd 8.2.15)
- Browser: Chrome 123.0.0.0
- OS: macOS
- Theme: Twenty Twenty-Four 1.0
- MU Plugins: None activated
- Plugins:
- Test Reports 1.1.0
Actual Results
- ✅ Added changes are working as expected with given PR.
Additional Notes
- Any additional details worth mentioning.
Supplemental Artifacts
Add as Attachment
This ticket was mentioned in Slack in #core by andr3ribeiro. View the logs.
8 months ago
@ironprogrammer commented on PR #6260:
7 months ago
#6
Thanks for the PR, @andr3ribeiro! Perhaps a good addition to this would be to include the fonts dir "is writable" check found on the Filesystem Permissions tab. This work is something we could probably get merged early this cycle.
#7
@
6 months ago
Bug Report
Description
According to this report, the patch indicated works as expected.
PR tested: https://github.com/WordPress/wordpress-develop/pull/6260
Environment
- WordPress: 6.6-alpha-57778-src
- PHP: 7.4.33
- Server: nginx/1.25.1
- Database: mysqli (Server: 8.0.37 / Client: mysqlnd 7.4.33)
- Browser: Chrome 124.0.0.0
- OS: macOS
- Theme: Twenty Twenty-Four 1.0
- MU Plugins: None activated
- Plugins:
- Test Reports 1.1.0
Actual Results
- ✅ I have tested the added changes with the given PR and they are working as expected.
Attachment Screenshot at May 10 10-52-59.png added
#9
@
6 months ago
Bug Report
Description
This report validates whether the indicated patch works as expected.
PR tested: https://github.com/WordPress/wordpress-develop/pull/6260
Environment
- WordPress: 6.6-alpha-57778-src
- PHP: 7.4.33
- Server: nginx/1.23.2
- Database: mysqli (Server: 8.0.36 / Client: mysqlnd 7.4.33)
- Browser: Chrome 124.0.0.0
- OS: macOS
- Theme: Twenty Twenty-Four 1.0
- MU Plugins: None activated
- Plugins:
- Test Reports 1.1.0
Steps to Reproduce
Actual Results
- ✅ The PR is working like expected result.
#10
@
6 months ago
Bug Report
Description
According to this report, the patch indicated works as expected.
PR tested: https://github.com/WordPress/wordpress-develop/pull/6260
Environment
- WordPress: 6.6-alpha-57778-src
- PHP: 8.2.18
- Server: nginx/1.25.5
- Database: mysqli (Server: 8.0.37 / Client: mysqlnd 8.2.18)
- Browser: Chrome 124.0.0.0
- OS: macOS
- Theme: Twenty Twenty-Four 1.0
- MU Plugins: None activated
- Plugins:
- Test Reports 1.1.0
Expected Results
- ✅ The PR is working like expected result.
Additional Notes
- The result is working fine but the status is showing "Loading..."
#11
@
6 months ago
Bug Report
Description
According to this report, the patch indicated works as expected.
PR tested: https://github.com/WordPress/wordpress-develop/pull/6260
Environment
- WordPress: 6.6-alpha-57778-src
- PHP: 8.2.18
- Server: nginx/1.25.5
- Database: mysqli (Server: 8.0.37 / Client: mysqlnd 8.2.18)
- Browser: Chrome 124.0.0.0
- OS: macOS
- Theme: Twenty Twenty-Four 1.0
- MU Plugins: None activated
- Plugins:
- Test Reports 1.1.0
Actual Results
- ✅ The pr working is final as a expected result
#12
@
6 months ago
Bug Report
Description
According to this report, the patch indicated works as expected.
PR tested: https://github.com/WordPress/wordpress-develop/pull/6260
Environment
- WordPress: 6.6-alpha-57778-src
- PHP: 8.2.18
- Server: nginx/1.25.5
- Database: mysqli (Server: 8.0.37 / Client: mysqlnd 8.2.18)
- Browser: Chrome 124.0.0.0
- OS: macOS
- Theme: Twenty Twenty-Four 1.0
- MU Plugins: None activated
- Plugins:
- Test Reports 1.1.0
Actual Results
- ✅ PR worked fine from my end
Supplemental Artifacts
#13
@
6 months ago
Bug Report
Description
According to this report, the patch described works as expected.
PR tested: https://github.com/WordPress/wordpress-develop/pull/6260
Environment
WordPress: 6.6-alpha-57778-src
PHP: 7.4.33
Server: nginx/1.25.1
Database: mysqli (Server: 8.0.37 / Client: mysqlnd 7.4.33)
Browser: Chrome 124.0.0.0
OS: macOS
Theme: Twenty Twenty-Four 1.0
MU Plugins: None activated
Plugins:
Test Reports 1.1.0
Actual Results
✅ I tested the changes with the given PR and they work as expected.
This ticket was mentioned in Slack in #core-test by zunaid321. View the logs.
6 months ago
#15
@
6 months ago
Bug Report
Description
This report validates whether the indicated patch works as expected.
PR tested: https://github.com/WordPress/wordpress-develop/pull/6260
Environment
- WordPress: 6.6-alpha-57778-src
- PHP: 8.2.12
- Server: nginx/1.25.3
- Database: mysqli (Server: 8.0.36 / Client: mysqlnd 8.2.12)
- Browser: Chrome 124.0.0.0
- OS: Windows 10/11
- Theme: Twenty Twenty-Four 1.0
- MU Plugins: None activated
- Plugins:
- Test Reports 1.1.0
Expected Results
- ✅ PR worked fine but the status was stuck at "loading".
Supplemental Artifacts
This ticket was mentioned in Slack in #core-test by zunaid321. View the logs.
6 months ago
#17
@
6 months ago
Test Report
Description
According to this report, the patch described works as expected.
PR tested: https://github.com/WordPress/wordpress-develop/pull/6260
Environment
- WordPress: 6.6-alpha-57778-src
- PHP: 8.2.19
- Server: nginx/1.25.5
- Database: mysqli (Server: 8.0.37 / Client: mysqlnd 8.2.19)
- Browser: Chrome 124.0.0.0
- OS: Windows 10/11
- Theme: Twenty Twenty-One 2.2
- MU Plugins: None activated
- Plugins:
- Hello Dolly 1.7.2
- Test Reports 1.1.0
Actual Results
✅ I tested the changes with the given PR and they work as expected.
Screenshot:
#18
@
6 months ago
- Keywords commit added
Tested changes with mentioned the PR and it shows the font dir path and size to Site Health.
PR tested: https://github.com/WordPress/wordpress-develop/pull/6260
Environment
WordPress: 6.6
PHP: 8.1.23
Server: nginx
Database: mysqli
OS: Windows
✅ The font directory is showing correctly.
As this ticket has an adequate number of test reports, marking this for 'commit'.
#19
@
5 months ago
Test Report
Description
This report validates whether the indicated patch works as expected.
PR tested: https://github.com/WordPress/wordpress-develop/pull/6260
Environment
- WordPress: 6.6-alpha-57778-src
- PHP: 8.2.19
- Server: nginx/1.25.5
- Database: mysqli (Server: 8.0.37 / Client: mysqlnd 8.2.19)
- Browser: Chrome 125.0.0.0
- OS: Windows 10/11
- Theme: Twenty Twenty-Four 1.0
- MU Plugins: None activated
- Plugins:
- Test Reports 1.1.0
Expected Results
- ✅ PR worked fine but the status was stuck at "loading".
#20
@
5 months ago
- Owner set to audrasjb
- Status changed from new to accepted
Thanks everyone for testing 😅
The PR works fine on my side as well.
Self assigning for commit.
@audrasjb commented on PR #6260:
5 months ago
#21
I committed the changes suggested by @peterwilsoncc directly to the PR.
@audrasjb commented on PR #6260:
5 months ago
#23
Committed in https://core.trac.wordpress.org/changeset/58299
#24
follow-up:
↓ 25
@
5 months ago
- Keywords commit removed
@ironprogrammer I committed the current PR without the change you suggested, to make sure this enhancement can ship in time for 6.6 beta 1. We can either reopen this ticket for a follow-up patch or open a new one.
#25
in reply to:
↑ 24
@
5 months ago
Replying to audrasjb:
@ironprogrammer I committed the current PR without the change you suggested, to make sure this enhancement can ship in time for 6.6 beta 1. We can either reopen this ticket for a follow-up patch or open a new one.
Thanks, @audrasjb! I'll create a PR with the follow-up patch shortly (I've got it stashed somewhere).
This ticket was mentioned in PR #6718 on WordPress/wordpress-develop by @ironprogrammer.
5 months ago
#26
Follow-up to #6260.
Trac ticket: https://core.trac.wordpress.org/ticket/60719
@audrasjb commented on PR #6718:
5 months ago
#28
committed in https://core.trac.wordpress.org/changeset/58310
There could also be a general check whether
wp-content
itself is writable or not.Edit: this already exists!