WordPress.org
Get WordPress

Make WordPress Core

Opened 23 months ago

Closed 23 months ago

#60730 closed defect (bug) (fixed)

Fix typo in class-wp-plugin-dependencies.php

Reported by: presskopp's profile Presskopp Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.5 Priority: normal
Severity: normal Version:
Component: Plugins Keywords: has-patch dev-reviewed fixed-major
Focuses: Cc:

Description

just an ending space which can go up to space

Attachments (1)

60730.diff​ (658 bytes) - added by Presskopp 23 months ago.

Download all attachments as: .zip

Change History (12)

@Presskopp
23 months ago

#1 @Presskopp
23 months ago

  • Keywords has-patch added

#2 @SergeyBiryukov
23 months ago

  • Component changed from General to Plugins
  • Milestone changed from Awaiting Review to 6.5

#3 @SergeyBiryukov
23 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 57791:

Plugins: Remove extra space in a translatable string.

Follow-up to [57545].

Props Presskopp.
Fixes #60730.

#4 @SergeyBiryukov
23 months ago

  • Keywords dev-feedback added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backporting to the 6.5 branch after a second committer's review.

#5 follow-up: @afragen
23 months ago

There are now 2 sentences without an interval space. Perhaps a non-breaking space needs to be added?

This ticket was mentioned in ​Slack in #meta-i18n by presskopp. ​View the logs.
23 months ago

#7 in reply to: ↑ 5 ; follow-up: @Presskopp
23 months ago

Replying to afragen:

There are now 2 sentences without an interval space. Perhaps a non-breaking space needs to be added?

I don't think so because $circular_dependency_lines will be a not empty list

#8 in reply to: ↑ 7 @afragen
23 months ago

Replying to Presskopp:

Replying to afragen:

There are now 2 sentences without an interval space. Perhaps a non-breaking space needs to be added?

I don't think so because $circular_dependency_lines will be a not empty list

I think you are correct.

#9 @swissspidy
23 months ago

  • Keywords dev-reviewed added; dev-feedback removed

#10 @swissspidy
23 months ago

  • Keywords fixed-major added

#11 @SergeyBiryukov
23 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 57812:

Plugins: Remove extra space in a translatable string.

Follow-up to [57545].

Reviewed by swissspidy.
Merges [57791] to the to the 6.5 branch.

Props Presskopp, afragen.
Fixes #60730.

Note: See TracTickets for help on using tickets.