WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#60730 closed defect (bug) (fixed)

Fix typo in class-wp-plugin-dependencies.php

Reported by: Presskopp Owned by: SergeyBiryukov
Priority: normal Milestone: 6.5
Component: Plugins Version:
Severity: normal Keywords: has-patch dev-reviewed fixed-major
Cc: Focuses:

Description

just an ending space which can go up to space

Attachments (1)

60730.diff​ (658 bytes ) - added by Presskopp 3 years ago.

Download all attachments as: .zip

Change History (12)

@Presskopp
3 years ago

#1 @Presskopp
3 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
3 years ago

  • Component General → Plugins
  • Milestone Awaiting Review → 6.5

#3 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 57791:

Plugins: Remove extra space in a translatable string.

Follow-up to [57545].

Props Presskopp.
Fixes #60730.

#4 @SergeyBiryukov
3 years ago

  • Keywords dev-feedback added
  • Resolution fixed
  • Status closed → reopened

Reopening for backporting to the 6.5 branch after a second committer's review.

#5 follow-up: @afragen
3 years ago

There are now 2 sentences without an interval space. Perhaps a non-breaking space needs to be added?

This ticket was mentioned in ​Slack in #meta-i18n by presskopp. ​View the logs.
3 years ago

#7 in reply to: ↑ 5 ; follow-up: @Presskopp
3 years ago

Replying to afragen:

There are now 2 sentences without an interval space. Perhaps a non-breaking space needs to be added?

I don't think so because $circular_dependency_lines will be a not empty list

#8 in reply to: ↑ 7 @afragen
3 years ago

Replying to Presskopp:

Replying to afragen:

There are now 2 sentences without an interval space. Perhaps a non-breaking space needs to be added?

I don't think so because $circular_dependency_lines will be a not empty list

I think you are correct.

#9 @swissspidy
3 years ago

  • Keywords dev-reviewed added; dev-feedback removed

#10 @swissspidy
3 years ago

  • Keywords fixed-major added

#11 @SergeyBiryukov
3 years ago

  • Resolution → fixed
  • Status reopened → closed

In 57812:

Plugins: Remove extra space in a translatable string.

Follow-up to [57545].

Reviewed by swissspidy.
Merges [57791] to the to the 6.5 branch.

Props Presskopp, afragen.
Fixes #60730.

Note: See TracTickets for help on using tickets.