Make WordPress Core

Opened 3 months ago

Last modified 21 minutes ago

#60732 accepted enhancement

Update old document URLs to new ones

Reported by: mkismy's profile mkismy Owned by: audrasjb's profile audrasjb
Milestone: 6.6 Priority: normal
Severity: minor Version:
Component: General Keywords: has-patch
Focuses: docs Cc:

Description

Some articles that was in https://wordpress.org/documentation/ was moved under https://developer.wordpress.org/advanced-administration/ and the old URLs has a redirect.
However URLs in php files still refer to the old ones so I thought the URLs should be updated to avoid unnecessary redirects.

Attachments (3)

60732.patch (3.8 KB) - added by shailu25 3 months ago.
Patch Added
60732.2.patch (1.9 KB) - added by shailu25 8 weeks ago.
Patch Added
60732.3.patch (782 bytes) - added by shailu25 2 weeks ago.
Update old document URL With New URL in wp-admin/includes/ms.php

Download all attachments as: .zip

Change History (29)

This ticket was mentioned in PR #6240 on WordPress/wordpress-develop by @mkismy.


3 months ago
#1

  • Keywords has-patch added

Updated document urls that was moved under https://developer.wordpress.org/advanced-administration/ to avoid unnecessary redirects.

Trac ticket: https://core.trac.wordpress.org/ticket/60732

@huzaifaalmesbah commented on PR #6240:


3 months ago
#2

Good catch. Thanks for the PR. Looks good for me.

#3 @audrasjb
3 months ago

  • Milestone changed from Awaiting Review to 6.6

#4 @audrasjb
3 months ago

  • Owner set to audrasjb
  • Status changed from new to accepted

#5 @audrasjb
3 months ago

  • Focuses docs added
  • Keywords commit added
  • Version trunk deleted

Hello @mkismy and welcome to WordPress Core Trac!

Thanks, the PR looks good to me.

#6 @audrasjb
3 months ago

In 57793:

Docs: Update various HelpHub links to avoid unnecessary redirections.

This updates various WP-Admin related links that have been redirected to new HelpHub pages, to avoid unnecessary redirections.

Props mkismy.
See #60732, #60699.

#7 @audrasjb
3 months ago

That was a first pass for WP-Admin related files.
I'll handle other occurrences in a follow-up commit.

#8 @audrasjb
3 months ago

In 57794:

Coding Standards: Fix a WPCS indentation issue found in wp-admin/options-general.php after [57793].

See #60732.

#9 @SergeyBiryukov
3 months ago

In 57797:

Docs: Update the link to the WordPress Feeds article on Reading Settings screen.

Follow-up to [57793].

Props ignatiusjeroe, sabernhardt, shailu25.
Fixes #60736. See #60732.

#10 @audrasjb
3 months ago

#60738 was marked as a duplicate.

#11 @SergeyBiryukov
3 months ago

In 57798:

Docs: Update the link to the “Editing wp-config.php” article in wp-load.php.

Follow-up to [57793].

Props fanly, shailu25.
See #60738, #60732.

#12 @audrasjb
3 months ago

In 57800:

Docs: Update various HelpHub links located in bundled themes to avoid unnecessary redirections.

Props mkismy.
See #60732, #60699.

#13 @audrasjb
3 months ago

In 57801:

Docs: Update various HelpHub links to avoid unnecessary redirections.

Follow-up to [57793], [57798], [57800].

Props mkismy.
See #60732, #60699.

@shailu25
3 months ago

Patch Added

#14 @shailu25
3 months ago

I have updated some more links in 60732.patch that were still redirecting.

@mkismy commented on PR #6240:


3 months ago
#15

Thank you!

#16 @audrasjb
2 months ago

In 57854:

Docs: Update various HelpHub links to avoid unnecessary redirections.

Follow-up to [57793], [57798], [57800], [57801].

Props shailu25.
See #60732, #60699.

#17 follow-up: @estelaris
2 months ago

Unfortunately, there was a committed redirect of https://wordpress.org/documentation/article/embeds to the oEmbed article in developers handbook and it is wrong.

https://wordpress.org/documentation/article/embeds (this is the landing page for all the embed-type blocks) should not go to https://developer.wordpress.org/advanced-administration/wordpress/oembed (article about how to code oEmbed)

The redirect was raised in GitHub Redirection of developer articles still in the documentation site #91https://github.com/WordPress/wporg-documentation-2022/issues/91

Last edited 2 months ago by estelaris (previous) (diff)

#18 @audrasjb
2 months ago

  • Keywords commit removed

Thanks! Let's just wait to the redirection to be removed before updating core.

#19 in reply to: ↑ 17 @estelaris
2 months ago

Replying to estelaris:

The redirect was raised in GitHub Redirection of developer articles still in the documentation site #91https://github.com/WordPress/wporg-documentation-2022/issues/91

This has been fixed, @audrasjb you should be able to go ahead with your commit.

@shailu25
8 weeks ago

Patch Added

#20 follow-up: @shailu25
8 weeks ago

Added Patch as per suggested in above comment.

Last edited 8 weeks ago by shailu25 (previous) (diff)

#21 in reply to: ↑ 20 @SergeyBiryukov
5 weeks ago

Replying to shailu25:

Added Patch as per suggested in above comment.

Thanks for the patch! I think we can only change the user-facing link here, and leave the developer-oriented link in the WP_oEmbed class DocBlock as is.

#22 @SergeyBiryukov
5 weeks ago

In 58029:

Docs: Use correct URL for the Embeds documentation article.

Follow-up to [57793].

Props shailu25, estelaris, audrasjb.
See #60732.

@shailu25
2 weeks ago

Update old document URL With New URL in wp-admin/includes/ms.php

#23 @shailu25
2 weeks ago

I have found one more instance in wp-admin/includes/ms.php Line no 1172.

Added New Patch (60732.3.patch) for that to avoid unnecessary redirect.

Old URL: https://wordpress.org/documentation/article/network-admin-sites-screen/
New URL: https://developer.wordpress.org/advanced-administration/multisite/admin/

Last edited 2 weeks ago by shailu25 (previous) (diff)

#24 @SergeyBiryukov
2 weeks ago

In 58131:

Docs: Use more specific URLs for a few Network Admin HelpHub links.

This better reflects the originally intended destination of these links.

Follow-up to [57854].

See #60732, #60699.

#25 @SergeyBiryukov
2 weeks ago

In 58132:

Docs: Update a HelpHub link on Edit Site screen to avoid unnecessary redirection.

Follow-up to [17045], [20713], [41065], [45674], [55412], [57854], [58131].

Props shailu25.
See #60732, #60699.

#26 @oglekler
21 minutes ago

Can we close this ticket? It looks like all the necessary links have been changed. And by the way, we have a test to check whether links return code 200, isn't it right?

Note: See TracTickets for help on using tickets.