Opened 8 months ago
Closed 4 months ago
#60732 closed task (blessed) (fixed)
Update old document URLs to new ones
Reported by: | mkismy | Owned by: | audrasjb |
---|---|---|---|
Milestone: | 6.6 | Priority: | normal |
Severity: | minor | Version: | |
Component: | General | Keywords: | commit dev-reviewed |
Focuses: | docs | Cc: |
Description
Some articles that was in https://wordpress.org/documentation/ was moved under https://developer.wordpress.org/advanced-administration/ and the old URLs has a redirect.
However URLs in php files still refer to the old ones so I thought the URLs should be updated to avoid unnecessary redirects.
Attachments (4)
Change History (37)
This ticket was mentioned in PR #6240 on WordPress/wordpress-develop by @mkismy.
8 months ago
#1
- Keywords has-patch added
@huzaifaalmesbah commented on PR #6240:
8 months ago
#2
Good catch. Thanks for the PR. Looks good for me.
#5
@
8 months ago
- Focuses docs added
- Keywords commit added
- Version trunk deleted
Hello @mkismy and welcome to WordPress Core Trac!
Thanks, the PR looks good to me.
#7
@
8 months ago
That was a first pass for WP-Admin related files.
I'll handle other occurrences in a follow-up commit.
#14
@
8 months ago
I have updated some more links in 60732.patch that were still redirecting.
#17
follow-up:
↓ 19
@
8 months ago
Unfortunately, there was a committed redirect of https://wordpress.org/documentation/article/embeds to the oEmbed article in developers handbook and it is wrong.
https://wordpress.org/documentation/article/embeds (this is the landing page for all the embed-type blocks) should not go to https://developer.wordpress.org/advanced-administration/wordpress/oembed (article about how to code oEmbed)
The redirect was raised in GitHub Redirection of developer articles still in the documentation site #91https://github.com/WordPress/wporg-documentation-2022/issues/91
#18
@
8 months ago
- Keywords commit removed
Thanks! Let's just wait to the redirection to be removed before updating core.
#19
in reply to:
↑ 17
@
8 months ago
Replying to estelaris:
The redirect was raised in GitHub Redirection of developer articles still in the documentation site #91https://github.com/WordPress/wporg-documentation-2022/issues/91
This has been fixed, @audrasjb you should be able to go ahead with your commit.
#20
follow-up:
↓ 21
@
7 months ago
Added Patch as per suggested in above comment.
#21
in reply to:
↑ 20
@
7 months ago
Replying to shailu25:
Added Patch as per suggested in above comment.
Thanks for the patch! I think we can only change the user-facing link here, and leave the developer-oriented link in the WP_oEmbed
class DocBlock as is.
#23
@
6 months ago
I have found one more instance in wp-admin/includes/ms.php Line no 1172.
Added New Patch (60732.3.patch) for that to avoid unnecessary redirect.
Old URL: https://wordpress.org/documentation/article/network-admin-sites-screen/
New URL: https://developer.wordpress.org/advanced-administration/multisite/admin/
#26
@
5 months ago
Can we close this ticket? It looks like all the necessary links have been changed. And by the way, we have a test to check whether links return code 200, isn't it right?
#27
@
5 months ago
- Keywords has-patch removed
- Type changed from enhancement to task (blessed)
Instead closing it, let's switch it into a Task and keep it open for now so we can edit more URLs as they are discovered :)
#28
@
4 months ago
I have found two more instances
- wp-settings.php File line no 718
- /wp-admin/admin-ajax.php File line no 8
Added New Patch 60732.4.patch for that to avoid unnecessary redirect.
Old URL: https://codex.wordpress.org/AJAX_in_Plugins
New URL: https://developer.wordpress.org/plugins/javascript/ajax
#30
@
4 months ago
- Keywords commit dev-feedback added
Marking for a second committer sign off to backport 58672.
Updated document urls that was moved under
https://developer.wordpress.org/advanced-administration/
to avoid unnecessary redirects.Trac ticket: https://core.trac.wordpress.org/ticket/60732