Context Navigation

← Previous Ticket
Next Ticket →

#60742 closed defect (bug) (fixed)

Script Modules: Module src not filterable.

Reported by:	dd32	Owned by:	swissspidy
Priority:	normal	Milestone:	6.5
Component:	Script Loader	Version:	6.5
Severity:	normal	Keywords:	has-patch commit dev-reviewed fixed-major
Cc:		Focuses:

Description

The new Script Modules feature doesn't allow the URL being imported to be filtered, this means that it's not possible for plugins to either filter it to load from a CDN, or add/alter params (Such as we do on WordPress.org for cache issues).

At a minimum WP_Script_Modules::get_versioned_src() should have a filter, ideally it could re-use the script_loader_src filter for maximum compatibility with existing script-related filters, but it could use something specific like script_module_src if required for some reason.

Change History (8)

This ticket was mentioned in PR #6243 on WordPress/wordpress-develop by @dd32.

2 years ago #1

Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/60742

See https://github.com/WordPress/wporg-mu-plugins/issues/587

#2 @jorbin
2 years ago

Milestone Awaiting Review → 6.5

Moving to 6.5 for visibility.

#3 @swissspidy
2 years ago

Owner set to swissspidy
Status new → reviewing

#4 @swissspidy
2 years ago

Keywords commit dev-reviewed added

#5 @swissspidy
2 years ago

Resolution → fixed
Status reviewing → closed

In 57840:

Script Loader: Add new script_module_loader_src filter for the script module src.

Ensures parity with the script_loader_src filter for regular scripts, allowing the URL to be filtered, for example to load them from a CDN or alter query parameters.

Props dd32, peterwilsoncc, westonruter.
Fixes #60742.

@swissspidy commented on PR #6243:

2 years ago #6

Committed in https://core.trac.wordpress.org/changeset/57840

#7 @swissspidy
2 years ago

Keywords fixed-major added
Resolution fixed
Status closed → reopened

#8 @swissspidy
2 years ago

Resolution → fixed
Status reopened → closed

In 57844:

Script Loader: Add new script_module_loader_src filter for the script module src.

Ensures parity with the script_loader_src filter for regular scripts, allowing the URL to be filtered, for example to load them from a CDN or alter query parameters.

Reviewed by swissspidy.
Merges [57840] to the to the 6.5 branch.

Props dd32, peterwilsoncc, westonruter.
Fixes #60742.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#60742 closed defect (bug) (fixed)

Script Modules: Module src not filterable.

Description

Change History (8)

This ticket was mentioned in ​PR #6243 on ​WordPress/wordpress-develop by ​@dd32. 2 years ago #1

#2 @jorbin 2 years ago

#3 @swissspidy 2 years ago

#4 @swissspidy 2 years ago

#5 @swissspidy 2 years ago

​@swissspidy commented on ​PR #6243: 2 years ago #6

#7 @swissspidy 2 years ago

#8 @swissspidy 2 years ago