WordPress.org
Get WordPress

Make WordPress Core

Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#60757 closed defect (bug) (fixed)

Interactivity API: Fix invalid test @covers annotations

Reported by: jonsurrell's profile jonsurrell Owned by: jonsurrell's profile jonsurrell
Milestone: 6.6 Priority: normal
Severity: normal Version: 6.5
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

If the Interactivity API tests are run with coverage, they produce warnings about invalid @covers annotations, for example:

XDEBUG_MODE=coverage vendor/bin/phpunit --coverage-html ./artifacts/coverage/ --group interactivity-api --stop-on-warning

prints:

1) Tests_WP_Interactivity_API_WP_Bind::test_wp_bind_sets_attribute
"@covers ::process_directives" is invalid

Change History (6)

This ticket was mentioned in ​PR #6258 on ​WordPress/wordpress-develop by ​@jonsurrell.
6 months ago #1

  • Keywords has-patch has-unit-tests added

Fix invalid test @covers annotations

Trac ticket: https://core.trac.wordpress.org/ticket/60757

#2 @swissspidy
6 months ago

  • Keywords needs-patch added; has-patch has-unit-tests removed
  • Milestone changed from Awaiting Review to 6.6

​@jonsurrell commented on ​PR #6258:
6 months ago #3

👋 @c4rl0sbr4v0 @DAreRodz for review

#4 @gziolo
6 months ago

  • Keywords has-patch added; needs-patch removed

#5 @gziolo
6 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 57836:

Tests: Fix invalid @covers annotations for Interactivity API

Follow-up [57563], #60356.
Fixes #60757.
Props jonsurrell, cbravobernal, swissspidy.

Note: See TracTickets for help on using tickets.