![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 2 years ago
Closed 2 years ago
#60765 closed defect (bug) (duplicate)
Typography Presets
| Reported by: | ramonopoly | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Editor | Version: | 6.5 |
| Severity: | normal | Keywords: | has-patch has-unit-tests gutenberg-merge |
| Cc: | Focuses: |
Description
We should pass theme.json settings to global preset or style value-generating callbacks.
Currently value_func callable properties in PRESETS_METADATA do not have access to the current theme JSON settings.
An example:
wp_get_typography_font_size_value() needs to know other theme.json settings in order to correctly output values.
Styles generated by WP_Theme_JSON::get_stylesheet outside a WordPress instance, using custom settings will therefore have no effect.
See bug issue for further details: https://github.com/WordPress/gutenberg/issues/58135
This ticket is to sync the following Gutenberg PR: https://github.com/WordPress/gutenberg/pull/58362
Change History (3)
This ticket was mentioned in PR #6266 on WordPress/wordpress-develop by @ramonopoly.
2 years ago
#1
@ramonopoly commented on PR #6266:
2 years ago
#2
Already committed in
Work in progress, please come back later 😄
Trac ticket: https://core.trac.wordpress.org/ticket/60765