TimeZone select box compatibility with RTL directions

[farhad0]

This patch fixes the time zone select box compatibility with RTL directions It sets auto direction which makes the options value compatible with both RTL and LTR directions

This patch fixes the time zone select box compatibility with RTL directions It sets auto direction which makes the options value compatible with both RTL and LTR directions

Trac ticket: https://core.trac.wordpress.org/ticket/60770

---

[swissspidy]

@farhad0 Could you perhaps add before/after screenshots so that others looking at this ticket can better understand the problem you're trying to solve? Thanks!

[farhad0]

timezone-select-box-rtl-compatibility-before-after

[farhad0]

@swissspidy
Hi,
Here you are

[drysand]

i tested the patch and it does indeed align english text LTR and RTL text RTL, however it seems to align all the optiongroup headers LTR no matter the language

sorry about the separate images, im still getting used to trac

[sabernhardt]

#63184 was marked as a duplicate.

[sabernhardt]

In RTL (fa-IR):

• ​PR 6268 aligns every optgroup plus 'UTC' and all UTC offset options to the left, and the other options align right.
• ​PR 8600 aligns the options for 'UTC' and the UTC offsets to the left, but all optgroup labels and most options align to the right.

I would like to consider using the same alignment for the 'UTC' optgroup and its option (I prefer both aligned left in Firefox but both on the right seems better in Chrome).

[farhad0]

@sabernhardt
Hi,
The Chrome detects the direction of the text and align it automatically,
This is a way which many modern applications use and this works on Chrome and may be some other browsers

[SirLouen]

Updating keywords to reflect current status.

[khoipro]

I agreed with @farhad0 so we should have test if the modern browsers already support alignment without any extra code.

[olmostblue]

Hi, I have tested this fix with Chrome, Safari, Comet and Firefox.
Everything works fine on Firefox, all the rtl text are aligned to right and latin text on the left like in the After screenshot.
With Safari and Chromium based browser all the texts in the select options are aligned to the right.

[welcher]

6.9 Beta 1 is tomorrow and this doesn't look to be ready so I'm going to move it to the 7.0 milestone.

[farhad0]

@welcher

Hi,
This issue tested and it's ready
Please review that again
Thank you