Make WordPress Core

#60817 closed defect (bug) (worksforme)

Investigate potentially failing `test_should_set_chmod()` test

Reported by: swissspidy's profile swissspidy Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: dev-feedback
Focuses: Cc:

Description

This is a follow-up to #57774, which added a suite of new tests in 6.5. Since that milestone is soon closing, I am opening this to further investigate the \Tests_Filesystem_WpFilesystemDirect_Mkdir::test_should_set_chmod() test, which seems to fail on a certain host. See https://make.wordpress.org/hosting/test-results/r57860/wpmudevbot-r57860/

This could either be an issue with the host, core, or simply the test itself.

This test is also the last one with an is_windows() check. Would be good if we could get rid of this env-specific check and maybe rely on comparing with FS_CHMOD_DIR instead.

Change History (2)

#1 @xkon
13 months ago

Hey @swissspidy ,

Just commenting here to inform that we fixed the test from our side so it should be running fine now example: https://make.wordpress.org/hosting/test-results/r57860/wpmudevbot-r59516/ .

It was kind of a false-positive basically, I had the test running from an extra user and umask was kicking in. The test runner is being executed from the same user that handles the services now so it should be good :) .

#2 @swissspidy
13 months ago

  • Milestone Future Release deleted
  • Resolution set to worksforme
  • Status changed from new to closed

Awesome, thanks for sharing that update! I guess we can close this one then :)

Note: See TracTickets for help on using tickets.