Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#60819 closed defect (bug) (fixed)

Update the Google fonts JSON data URL to the latest version.

Reported by: mmaattiiaass Owned by: swissspidy
Priority: normal Milestone: 6.5
Component: Editor Version:
Severity: normal Keywords: has-patch commit fixed-major dev-reviewed
Cc: Focuses:

Description

Update the Google Fonts JSON data URL to the latest deployed version in the WordPress.org CDN.

Reference:
https://meta.trac.wordpress.org/ticket/7522
https://github.com/WordPress/google-fonts-to-wordpress-collection/pull/21

Change History (13)

This ticket was mentioned in PR #6300 on WordPress/wordpress-develop by @mmaattiiaass.


2 years ago
#1

  • Keywords has-patch added

## What ?

Update the Google Fonts JSON data URL to the latest deployed version in the WordPress.org CDN.

Reference:
https://meta.trac.wordpress.org/ticket/7522
https://github.com/WordPress/google-fonts-to-wordpress-collection/pull/21

---

Trac ticket: https://core.trac.wordpress.org/ticket/60819

#2 @mikachan
2 years ago

  • Milestone Awaiting Review6.5

#3 follow-up: @swissspidy
2 years ago

  • Keywords commit dev-feedback added

Why is this change done so late in the cycle? Seems like this could have been done before RC 1.

#4 in reply to: ↑ 3 @mmaattiiaass
2 years ago

Replying to swissspidy:

Why is this change done so late in the cycle? Seems like this could have been done before RC 1.

I think it is because this URL change doesn't add logic or functional change, so from my point of view, the risk is very low. It only removes some data from the JSON file that no is longer needed after #60509.

#5 @swissspidy
2 years ago

That is still not a reason for changing it only right before release instead of before RC.

#6 @mmaattiiaass
2 years ago

There's no functional change, so if the change is not allowed to land, it's fine too.

#7 @huzaifaalmesbah
2 years ago

The only noticeable alteration is the URL change, with all other aspects remaining unchanged.

#8 @swissspidy
2 years ago

  • Component GeneralEditor

#9 @swissspidy
2 years ago

  • Owner set to swissspidy
  • Resolutionfixed
  • Status newclosed

In 57871:

Editor: Update the Google Fonts font collection URL to the latest version for 6.5.

Props mmaattiiaass.
Fixes #60819.

#11 @swissspidy
2 years ago

  • Keywords fixed-major added
  • Resolution fixed
  • Status closedreopened

#12 @peterwilsoncc
2 years ago

  • Keywords dev-reviewed added; dev-feedback removed

[57871] approved for backport. I've confirmed new URL provides and expected response. The removal of the categories from the JSON response has no effect on the UI.

#13 @swissspidy
2 years ago

  • Resolutionfixed
  • Status reopenedclosed

In 57875:

Editor: Update the Google Fonts font collection URL to the latest version for 6.5.

Reviewed by peterwilsoncc.
Merges [57871] to the 6.5 branch.

Props mmaattiiaass.
Fixes #60819.

Note: See TracTickets for help on using tickets.