Menu item label "Appearance > Patterns" not properly translated

[jdy68]

Bug Report

Description

The string "Patterns" under Appearance menu is not translated, but the translation exists.

Environment

• WordPress: 6.5-RC3-57856
• PHP: 8.1.15
• Server: Apache/2.4.54 (Win64) OpenSSL/1.1.1q mod_fcgid/2.3.10-dev
• Database: mysqli (Server: 8.0.30 / Client: mysqlnd 8.1.15)
• Browser: Chrome 122.0.0.0 (Windows 10/11)
• Theme: Twenty Fifteen 3.6
• MU-Plugins: Aucune activée
• Plugins:
  • WordPress Beta Tester 3.5.5

Steps to Reproduce

1.Install WordPress 6.5-RC3
2.Install a classic theme like Twenty-Twenty
3.Select Français/French or Espanol or Deutsch in Settings > General > Site Language
🐞 Go to Appearance menu and see that "Patterns" is not translated.

Expected Results

1. ✅ "Patterns" must be translated.

Actual Results

1. ❌ "Patterns" is not translated even though the translation exists.

For example in fr_FR locale:
​https://translate.wordpress.org/projects/wp/dev/fr/default/?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=10187524&filters%5Btranslation_id%5D=76090580

[jdy68]

screenshot of Appearance menu with Patterns not translated

[audrasjb]

I can reproduce the issue on my side. But after looking on the code at a glance, I can't see how it's happening.

Moving to 6.5 as it is a very annoying issue since the interface won't be consistent on a large amount of websites ("Patterns" is not used anywhere else in the interface on localized installations).

Ping @swissspidy: it would be nice to fix this before RC4.

[audrasjb]

Ah probably we should just replace __ function with _x 🙃

[kebbet]

Introduced in https://core.trac.wordpress.org/changeset/57543

[kebbet]

Replying to audrasjb:

Ah probably we should just replace __ function with _x 🙃

Or add a translators comment to __( 'Patterns' ) like /* Translators: Admin menu item. */ or similar.

[audrasjb]

Hopefully replacing __ with _x wouldn't cause any string change, but I'm not sure about this :)
Edit: no the string will probably be fuzzied.

Note: Even if there is a string change, I think it's worth fixing this issue.

https://core.trac.wordpress.org/ticket/60825

We should just use _x( 'Patterns', 'site editor menu item' ) instead of __( 'Patterns', 'site editor menu item' )

No translator comment or anything

[swissspidy]

Heya, yes let's use _x( 'Patterns', 'site editor menu item' ) here like it was intended.

It will cause a new translation string to appear but that will basically have the same translation as the others, so should be fine.

Alternatively, if we're worried about that, we simply remove the text domain for 6.5 and in 6.5.1 we use the proper context. Then there won't be a string change in 6.5

Doing some research on swedish translations, I think no comment at all shuld be best, as _x will genereate a new string

​https://translate.wordpress.org/projects/wp/dev/sv/default/?filters%5Bterm%5D=Patterns&filters%5Bcase_sensitive%5D=yes&filters%5Bterm_scope%5D=scope_any&filters%5Bstatus%5D=current_or_waiting_or_fuzzy_or_untranslated&filters%5Buser_login%5D=&filter=Apply+Filters&sort%5Bby%5D=references&sort%5Bhow%5D=desc

That is correct. See the discussion on the ticket about that. We have a couple of options here.

[kebbet]

sv_SE has been translated fully for 6.5.
Testing the options:

• _x( 'Patterns', 'site editor menu item' ) displays Patterns in admin menu.
• __( 'Patterns' ) displays Mönster in admin menu.

So going with __() is my suggestion.

[jdy68]

But the code is already
( 'Patterns' )
and it doesn't work

[audrasjb]

Yeah, using __( 'Patterns' ) would indeed fix the issue without introducing any string change.

@swissspidy another option would be:

1. Use __( 'Patterns' ) as a quick fix for RC4, so we don't get a fuzzy string
2. Replace it with _x in 6.5.1 so we get the translator comment back

Note: if we're already going to have other string changes in RC4, we can probably afford to introduce a fuzzy string, though.

[audrasjb]

Replying to jdy68:

But the code is already

__( 'Patterns' )

and it doesn't work

The current code is __( 'Patterns', 'site editor menu item' ).

It doesn't work because __() is not supposed to have a translator comment as a second parameter. The second parameter of __() is the text domain, see ​https://developer.wordpress.org/reference/functions/__/.

[swissspidy]

another option would be:

Yes that's what I meant above.

Note: if we're already going to have other string changes in RC4, we can probably afford to introduce a fuzzy string, though.

I think so too. Looks like we're changing some strings on the about page.

Using __( 'Patterns' ) looks like our best option there.
Approving this for commit.

[audrasjb]

I think we're good to go with the proposed PR.

[audrasjb]

In 57864:

I18n: Ensure "Patterns" menu item is translatable.

This changeset updates a translation string to ensure the "Patterns" menu item introduced in [57543] is translatable.
This quickfix simply removes the erroneous context parameter so no new string is introduced during WP 6.5 string freeze period. A follow-up changeset will be needed to replace the current __() function with _x() and put back the context parameter.

Follow-up to [57543].

Props jdy68, audrasjb, kebbet, swissspidy.
Fixes #60825.

[audrasjb]

Reopening for backport consideration.
@swissspidy can you sign-off this for 6.5 please?

[swissspidy]

@audrasjb Are you handling the follow-up as well?

https://core.trac.wordpress.org/changeset/57864

[audrasjb]

yeah sure! thanks for the review ;)

[audrasjb]

In 57866:

I18n: Ensure "Patterns" menu item is translatable.

This changeset updates a translation string to ensure the "Patterns" menu item introduced in [57543] is translatable.
This quickfix simply removes the erroneous context parameter so no new string is introduced during WP 6.5 string freeze period. A follow-up changeset will be needed to replace the current __() function with _x() and put back the context parameter.

Follow-up to [57543].

Reviewed by swissspidy.
Merges [57864] to the to the 6.5 branch.

Props jdy68, audrasjb, kebbet, swissspidy.
Fixes #60825.