Make WordPress Core

Opened 4 months ago

Closed 3 months ago

#60827 closed defect (bug) (fixed)

Patterns menu item, put back the context parameter.

Reported by: kebbet's profile kebbet Owned by: audrasjb's profile audrasjb
Milestone: 6.5.3 Priority: normal
Severity: normal Version: 6.5
Component: I18N Keywords: good-first-bug has-patch fixed-major i18n-change dev-reviewed
Focuses: Cc:

Description

This is a follow up for the next minor release, 6.5.1 and the previous ticket #60825

The commit message by @audrasjb in [57864] stated: A follow-up changeset will be needed to replace the current __() function with _x() and put back the context parameter.

This is what should replace the call to __():
_x( 'Patterns', 'site editor menu item' )

Change History (18)

#1 @swissspidy
4 months ago

  • Focuses ui removed
  • Milestone changed from Awaiting Review to 6.5.1

#2 @audrasjb
4 months ago

  • Component changed from Administration to I18N
  • Status changed from assigned to accepted

Related: #60825

#3 @narenin
4 months ago

Hi,

I have fixed this in my PR.

Please find my PR : https://github.com/WordPress/wordpress-develop/pull/6326

Last edited 4 months ago by narenin (previous) (diff)

This ticket was mentioned in PR #6326 on WordPress/wordpress-develop by @narenin.


4 months ago
#4

  • Keywords has-patch added

#6 @audrasjb
4 months ago

  • Keywords commit added

Thanks for the PR @narenin and @nestea29950. Approving PR6327 for commit.

@audrasjb commented on PR #6326:


4 months ago
#7

Closing in favor of PR#6327

#8 @audrasjb
4 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 57887:

I18n: Add context to the "Patterns" translatable string for the related admin menu item.

This changeset put back the context parameter of the "Patterns" string which was previously removed to fix a translation issue without introducing a string change during WP 6.5 string freeze period.

Follow-up to [57864].

Props kebbet, narenin, nestea29950.
Fixes #60827.

#10 @audrasjb
4 months ago

  • Keywords fixed-major i18n-change added; commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 6.5.1 backport consideration.

#11 @audrasjb
4 months ago

  • Keywords dev-feedback added

#12 @swissspidy
4 months ago

  • Keywords dev-reviewed added; dev-feedback removed

This ticket was mentioned in Slack in #core by jorbin. View the logs.


4 months ago

#14 @davidbaumwald
4 months ago

  • Milestone changed from 6.5.1 to 6.5.2

Milestone renamed

#15 @jorbin
4 months ago

  • Milestone changed from 6.5.2 to 6.5.3

This ticket was mentioned in Slack in #core by jorbin. View the logs.


3 months ago

This ticket was mentioned in Slack in #core by jorbin. View the logs.


3 months ago

#18 @audrasjb
3 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 58038:

I18n: Add context to the "Patterns" translatable string for the related admin menu item.

This changeset put back the context parameter of the "Patterns" string which was previously removed to fix a translation issue without introducing a string change during WP 6.5 string freeze period.

Follow-up to [57864].

Reviewed by audrasjb, jorbin.
Merges [57887] to the to the 6.5 branch.
Props kebbet, narenin, nestea29950.
Fixes #60827.

Note: See TracTickets for help on using tickets.