Make WordPress Core

Opened 2 months ago

Closed 2 months ago

#60845 closed task (blessed) (fixed)

Relocate font directory to uploads sub-directory.

Reported by: peterwilsoncc's profile peterwilsoncc Owned by: peterwilsoncc's profile peterwilsoncc
Milestone: 6.5 Priority: high
Severity: normal Version:
Component: Editor Keywords: has-patch has-unit-tests commit fixed-major dev-reviewed
Focuses: Cc:

Description

Per https://make.wordpress.org/core/2024/03/25/wordpress-6-5-release-delayed-1-week/ it's being decided to relocate font files to a sub-directory of the uploads folder following community feedback.

Change History (9)

#1 @desrosj
2 months ago

  • Keywords has-patch added

This ticket was mentioned in PR #6317 on WordPress/wordpress-develop by @mmaattiiaass.


2 months ago
#2

  • Keywords has-unit-tests added

## What?
Default fonts directory to wp-content/uploads/fonts instead of wp-content/fonts.

## Context links:

---
Trac ticket: https://core.trac.wordpress.org/ticket/60845

---
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

_Edit: Add third context link and trac ticket -- @peterwilsoncc_

#3 @peterwilsoncc
2 months ago

  • Keywords commit added
  • Owner set to peterwilsoncc
  • Status changed from new to assigned

The linked pull request:

  • updates the directory to uploads/fonts or the multi-site sub-site equivalent
  • updates the unit tests
  • adds a multisite sub-site test

It already has four committers' approval, including @davidbaumwald (WP 6.5 co-core tech lead) so is ready for commit. Self assigning to do the commit shortly.

#4 @peterwilsoncc
2 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 57878:

Editor: Relocate font files uploads to the uploads directory.

Relocate the upload of font files uploaded via the Font Library feature to the wp-content/uploads/fonts (or multisite equivalent) directory.

This accounts for immutable file systems in which directories are unable to be created within wp-content and deploy processes which require special consideration of the uploads directory to ensure it remains persistent between deploys.

Props azaozz, burnuser, cbirdsong, christopherplus, costdev, davidbaumwald, desrosj, elrae, euthelup, get_dave, grantmkin, hellofromtonya, janthiel, jazzs3quence, johnbillion, jorbin, justlevine, kraftner, matveb, mcsf, mmaattiiaass, nico23, peterwilsoncc, priethor, rmccue, samuelsidler, swissspidy, youknowriad.
Fixes #60845.

#6 @peterwilsoncc
2 months ago

  • Keywords dev-feedback fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport consideration to the 6.5 branch.

#7 @davidbaumwald
2 months ago

  • Keywords dev-reviewed added; dev-feedback removed

Looks good to backport to the 6.5 branch. Thanks @peterwilsoncc!

#8 @peterwilsoncc
2 months ago

@davidbaumwald Thanks David, due to merge conflicts [57868] for #60652 will need to go in prior to this so I'll hold off on this for now.

#9 @swissspidy
2 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 57880:

Editor: Relocate font files uploads to the uploads directory.

Relocate the upload of font files uploaded via the Font Library feature to the wp-content/uploads/fonts (or multisite equivalent) directory.

This accounts for immutable file systems in which directories are unable to be created within wp-content and deploy processes which require special consideration of the uploads directory to ensure it remains persistent between deploys.

Reviewed by davidbaumwald.
Merges [57878] to the 6.5 branch.

Props azaozz, burnuser, cbirdsong, christopherplus, costdev, davidbaumwald, desrosj, elrae, euthelup, get_dave, grantmkin, hellofromtonya, janthiel, jazzs3quence, johnbillion, jorbin, justlevine, kraftner, matveb, mcsf, mmaattiiaass, nico23, peterwilsoncc, priethor, rmccue, samuelsidler, swissspidy, youknowriad.
Fixes #60845.

Note: See TracTickets for help on using tickets.