Make WordPress Core

Opened 2 weeks ago

Closed 13 days ago

Last modified 13 days ago

#60857 closed defect (bug) (fixed)

Freedoms.png missing from images folder

Reported by: sjnbham's profile sjnbham Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.6 Priority: normal
Severity: trivial Version: 5.8
Component: Help/About Keywords: good-first-bug has-patch
Focuses: css, administration Cc:

Description

/wp-admin/images/freedoms.png seems to be called on all admin pages for a default install of WP CORE hosted by WPEngine. Not sure why it's being called on every admin page or why it's not in the images folder. There are four SVGs in the images folder that are related to the /wp-admin/freedoms.php page (freedom-1.svg, etc.). Maybe the PNG and whatever's calling it just needs to be cleaned up in the next release?

Change History (4)

#1 @SergeyBiryukov
2 weeks ago

  • Component changed from Administration to Help/About
  • Focuses css administration added
  • Keywords needs-refresh good-first-bug added; 2nd-opinion removed
  • Milestone changed from Awaiting Review to 6.6
  • Version changed from 6.4.3 to 5.8

Hi there, welcome back to WordPress Trac! Thanks for the ticket.

Good catch, the wp-admin/images/freedoms.png file was removed in [51356] and [51459], but is still referenced in wp-admin/css/about.css:

.freedoms-php .column .freedoms-image {
	background-image: url('../images/freedoms.png');
	background-size: 100%;
	padding-top: 100%;
}

.freedoms-php .column:nth-of-type(2) .freedoms-image {
	background-position: 0 34%;
}

.freedoms-php .column:nth-of-type(3) .freedoms-image {
	background-position: 0 66%;
}

.freedoms-php .column:nth-of-type(4) .freedoms-image {
	background-position: 0 100%;
}

I think this whole section can be removed, as the .freedoms-image selector is no longer used in core as of [51356].

This ticket was mentioned in PR #6339 on WordPress/wordpress-develop by @niravsherasiya7707.


2 weeks ago
#2

  • Keywords has-patch added; needs-refresh removed

#3 @SergeyBiryukov
13 days ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 57911:

Help/About: Remove unused CSS previously intended for the Freedoms screen.

Follow-up to [44264], [45278], [49219], [49479], [51356], [51459].

Props sjnbham, niravsherasiya7707.
Fixes #60857.

@SergeyBiryukov commented on PR #6339:


13 days ago
#4

Thanks for the PR! Merged in r57911.

Note: See TracTickets for help on using tickets.