Make WordPress Core

Opened 9 months ago

Last modified 3 weeks ago

#60859 new defect (bug)

Twenty Twenty-one: Table block selected text color not appear when we select "Stripes" style.

Reported by: viralsampat's profile viralsampat Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: ui, css Cc:

Description

Hello,

I have reviewed the "Table block" and found that its "selected text" color does not appear properly on both editor/front sides when we changed its style from default to stripes. I have checked this issue with two different themes(Twenty Twenty Two & Twenty Twenty-one).

Here, I have attached its video.

Issue: https://share.cleanshot.com/wtCDMKhGbYqVHMK41hXf

Environment info:


  • WordPress version: WordPress 6.5-beta2 running,
  • Theme: Twenty Twenty-one Version: 2.1
  • Browser: Google Chrome, Version 123.0.6312.59 (Official Build) (arm64)
  • Device: MacBook Air M1
  • OS: macOS 14.4 (23E214)
  • Gutenberg plugin: Version 17.9.0

Thanks,

Attachments (3)

60859.2.patch (1.2 KB) - added by viralsampat 7 months ago.
I have checked above mentioned issue and I have resolved it and added patch. Also, I have attached screenshot after resolved this issue.
after_resolved_isse.png (351.0 KB) - added by viralsampat 7 months ago.
Back-end
after_resolved_isse_front-end.png (147.2 KB) - added by viralsampat 7 months ago.
Front-end

Download all attachments as: .zip

Change History (9)

#1 @karmatosed
7 months ago

  • Keywords reporter-feedback added; dev-feedback removed

Unfortunately the link above doesn't work and I do see stripes working. I am unsure what selected text color means. Could you perhaps provide some more instructions so I can follow. If possible not in a video but in steps and / or screenshots @viralsampat.

#2 @viralsampat
7 months ago

Hello @karmatosed

Thank you so much for the update.

I have checked attached link and it was no longer active.

Here, I have checked this issue and prepared its new video. Also, I have provided its step to replicate this issue.

Issue: https://www.awesomescreenshot.com/video/27648230?key=166a5315cc67e5cbfd136c32b46038e2

  • First of all active Twenty Twenty Two or Twenty Twenty-one theme.
  • Select table block.
  • Add text into the table column.
  • Change text color from block setting.
  • Now, change background from block setting.
  • Change table style from default to stripes

We can see that text color changed to black instead of selected color from block setting. I think that it should not be change when we change table background color. It should be same which we selected.

Thanks,

@viralsampat
7 months ago

I have checked above mentioned issue and I have resolved it and added patch. Also, I have attached screenshot after resolved this issue.

@viralsampat
7 months ago

Back-end

#3 @karmatosed
7 months ago

  • Milestone changed from Awaiting Review to Future Release

#4 @karmatosed
5 months ago

  • Keywords needs-testing has-patch added; reporter-feedback removed

In the past we have had issues removing default colors using inherit for classic situations and I would like therefore to have testing done on this. Let's ensure that happens.

Last edited 5 months ago by karmatosed (previous) (diff)

#5 @sainathpoojary
3 weeks ago

Reproduction Report

Description

This report validates whether the issue can be reproduced.

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 8.2.25
  • Server: nginx/1.27.2
  • Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.25)
  • Browser: Chrome 131.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty-One 2.4
  • MU Plugins: None activated
  • Plugins: Test Reports 1.2.0

Actual Results

  1. ✅ The text color is not applied when the ‘stripes’ style is used with a background color.

Supplemental Artifacts

Video: https://utfs.io/f/PL8E4NiPUWyOZFhd49GJy8ZehF2cujNOPAoRHWdYL45tbmXG

#6 @sainathpoojary
3 weeks ago

  • Keywords needs-testing removed

Test Report

Description

This report validates whether the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/60859/60859.2.patch

Environment

  • WordPress: 6.8-alpha-59274-src
  • PHP: 8.2.25
  • Server: nginx/1.27.2
  • Database: mysqli (Server: 8.0.40 / Client: mysqlnd 8.2.25)
  • Browser: Chrome 131.0.0.0
  • OS: macOS
  • Theme: Twenty Twenty-One 2.4
  • MU Plugins: None activated
  • Plugins: Test Reports 1.2.0

Actual Results

  1. ✅ The issue where the text color was not applied when the ‘Stripes’ style was used with a background color has been resolved with this patch.

Supplemental Artifacts

Video: https://utfs.io/f/PL8E4NiPUWyOIMQlcVYu0ijZ26tMJfXmSNwkIeaAogPOvYVl

Note: See TracTickets for help on using tickets.