WordPress.org
Get WordPress

Make WordPress Core

Opened 10 months ago

Closed 2 weeks ago

#60921 closed enhancement (wontfix)

Coding standard change

Reported by: mujuonly's profile mujuonly Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: General Keywords: has-patch
Focuses: coding-standards Cc:

Description

Strict comparison in wp-admin/includes/deprecated.php

Change History (4)

#2 @mukesh27
10 months ago

  • Version trunk deleted

Hi there!

That function is deprecated do we still needs to update it?

#3 follow-up: @SergeyBiryukov
6 months ago

  • Keywords close added

Thanks for the PR! There are many more coding standard issues in that file, but all those functions are deprecated, so this file is excluded from WPCS checks​, and addressing those issues does not seem to provide any benefit.

#4 in reply to: ↑ 3 @desrosj
2 weeks ago

  • Keywords close removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Replying to SergeyBiryukov:

Thanks for the PR! There are many more coding standard issues in that file, but all those functions are deprecated, so this file is excluded from WPCS checks​, and addressing those issues does not seem to provide any benefit.

I agree with closing this one out. Setting to wontfix.

Note: See TracTickets for help on using tickets.