![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 2 years ago
Closed 18 months ago
#60921 closed enhancement (wontfix)
Coding standard change
| Reported by: | mujuonly | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | General | Version: | |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: | coding-standards |
Description
Strict comparison in wp-admin/includes/deprecated.php
Change History (4)
This ticket was mentioned in PR #6360 on WordPress/wordpress-develop by @mujuonly.
2 years ago
#1
#2
@
2 years ago
- Version trunk
Hi there!
That function is deprecated do we still needs to update it?
#3
follow-up:
↓ 4
@
2 years ago
- Keywords close added
Thanks for the PR! There are many more coding standard issues in that file, but all those functions are deprecated, so this file is excluded from WPCS checks, and addressing those issues does not seem to provide any benefit.
#4
in reply to: ↑ 3
@
18 months ago
- Keywords close removed
- Milestone Awaiting Review
- Resolution → wontfix
- Status new → closed
Replying to SergeyBiryukov:
Thanks for the PR! There are many more coding standard issues in that file, but all those functions are deprecated, so this file is excluded from WPCS checks, and addressing those issues does not seem to provide any benefit.
I agree with closing this one out. Setting to wontfix.
Trac ticket: https://core.trac.wordpress.org/ticket/60921