calling get_post_type_object in wp-admin/includes/post.php may return null

[pcarvalho]

There's no guard to check the return of get_post_type_object, going straight to use labels and then all_items

/wp-admin/includes/post.php:1816

$sendback_text = get_post_type_object( $post->post_type )->labels->all_items;

​get_post_type_object returns:

WP_Post_Type|null WP_Post_Type object if it exists, null otherwise.

if valid, i can provide a patch.

[SergeyBiryukov]

Replying to pcarvalho:

if valid, i can provide a patch.

Hi there, thanks for the ticket! This does seem valid, would you be interested in working on a patch?

Introduced in [24527] / #24547.

This PR adds a check for the function get_post_type_object not returning null.
https://core.trac.wordpress.org/ticket/60947

[SergeyBiryukov]

In 58983:

Posts, Post Types: Check if the post type exists in _admin_notice_post_locked().

This adds a guard to verify the result of get_post_type_object() before retrieving the all_items label, as the function returns null if the post type does not exist.

Follow-up to [24527].

Props pcarvalho, akshat280, mukesh27, SergeyBiryukov.
Fixes #60947.

Thanks for the PR! Merged in r58983.

[akshat2802]

Hi @SergeyBiryukov ,

Thank you for the mention in this ticket. However, it seems that my username has been listed incorrectly as "akshat280." My correct username is "akshat2802." Could you kindly update the reference?

Regards
Akshat

[sabernhardt]

My correct username is "akshat2802."

It's corrected in Core Props.

[SergeyBiryukov]

Replying to akshat2802:

Thank you for the mention in this ticket. However, it seems that my username has been listed incorrectly as "akshat280."

Sorry for the typo, and thanks to @sabernhardt for correcting it :)