Make WordPress Core

Opened 2 months ago

Closed 2 months ago

#60961 closed defect (bug) (invalid)

WP_HTML_Processor::is_void() is missing deprecated tags

Reported by: westonruter's profile westonruter Owned by:
Milestone: Priority: normal
Severity: normal Version: 6.4
Component: HTML API Keywords:
Focuses: Cc:

Description (last modified by westonruter)

In a pull request to reuse WP_HTML_Processor::is_void() instead of my manual list of void tags, I noticed that unit tests were failing for tests involving the BASEFONT, BGSOUND, FRAME, KEYGEN,, and PARAM tags. These deprecated/non-nonstandard tags are treated as void by the browser, and yet they are not currently included in WP_HTML_Processor::is_void().

Including BASEFONT, BGSOUND, and KEYGEN may not be warranted considering that none of these are seen in HTTP Archive (see sheet). Nevertheless, FRAME and PARAM are present, even though they round to 0.0% of pages.

Change History (3)

#1 @westonruter
2 months ago

  • Description modified (diff)

#2 @dmsnell
2 months ago

is missing deprecated tags

you had me there for a second. I thought this was about @deprecated, but I realize it's about the missing tags in HTML which have been deprecated.

I guess all we need to do is backport the list of tags from 6.5 into 6.4? I believe that the list is correct in 6.5 already - can you confirm?

#3 @westonruter
2 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

Oh! Yes, I see the list has been updated in 6.5 to include these deprecated tags. Sorry I missed that.

Note: See TracTickets for help on using tickets.