Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #60961


Ignore:
Timestamp:
04/08/2024 05:33:58 PM (3 months ago)
Author:
westonruter
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #60961 – Description

    initial v1  
    1 In a [https://github.com/WordPress/performance/pull/1115 pull request] to reuse `WP_HTML_Processor::is_void()` instead of my manual list of void tags, I noticed that unit tests were failing for tests involving the `BASEFONT`, `BGSOUND`, `KEYGEN,`, and `PARAM` tags. These deprecated/non-nonstandard tags are treated as void by the browser, and yet they are not currently included in `WP_HTML_Processor::is_void()`.
     1In a [https://github.com/WordPress/performance/pull/1115 pull request] to reuse `WP_HTML_Processor::is_void()` instead of my manual list of void tags, I noticed that unit tests were failing for tests involving the `BASEFONT`, `BGSOUND`, `FRAME`, `KEYGEN,`, and `PARAM` tags. These deprecated/non-nonstandard tags are treated as void by the browser, and yet they are not currently included in `WP_HTML_Processor::is_void()`.
    22
    3 Including `BASEFONT`, `BGSOUND`, and `KEYGEN` may not be warranted considering that none of these are seen in HTTP Archive (see [https://docs.google.com/spreadsheets/d/1grkd2_1xSV3jvNK6ucRQ0OL1HmGTsScHuwA8GZuRLHU/edit#gid=571472591 sheet]). Nevertheless, `PARAM` is present, even though it rounds to 0.0% of pages.
     3Including `BASEFONT`, `BGSOUND`, and `KEYGEN` may not be warranted considering that none of these are seen in HTTP Archive (see [https://docs.google.com/spreadsheets/d/1grkd2_1xSV3jvNK6ucRQ0OL1HmGTsScHuwA8GZuRLHU/edit#gid=571472591 sheet]). Nevertheless, `FRAME` and `PARAM` are present, even though they round to 0.0% of pages.