Opened 5 months ago
Closed 4 months ago
#61023 closed enhancement (fixed)
Add 'label' argument to register_setting
Reported by: | Mamaduka | Owned by: | Mamaduka |
---|---|---|---|
Milestone: | 6.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Options, Meta APIs | Keywords: | has-patch has-unit-tests commit |
Focuses: | Cc: |
Description
A sync ticket for https://github.com/WordPress/gutenberg/pull/59243.
The 'label' will displayed to users when editing core or custom settings via block editors. It avoids hardcoding Settings labels and improves extensibility.
Please take a look at the original issue for additional details: https://github.com/WordPress/gutenberg/issues/41637.
Change History (11)
This ticket was mentioned in PR #6495 on WordPress/wordpress-develop by @Mamaduka.
4 months ago
#1
- Keywords has-patch added; needs-patch removed
@Mamaduka commented on PR #6495:
4 months ago
#3
Thanks for the review, @TimothyBJacobs 🙇
The wp-api-generated.js file will need to be rebuilt before committing.
I always forget about it. I wish there was a pre-commit hook for it. To update it, I need to run a full PHP test suite, correct?
@TimothyBlynJacobs commented on PR #6495:
4 months ago
#4
Yeah the process is a bit frustrating. Was GB active on your checkout?
@Mamaduka commented on PR #6495:
4 months ago
#5
Was GB active on your checkout?
No. I've got a separate installation just for core patches.
@ellatrix commented on PR #6495:
4 months ago
#6
@Mamaduka Is this good to merge?
@Mamaduka commented on PR #6495:
4 months ago
#7
@ellatrix, yes, it's good to be merged.
@ellatrix commented on PR #6495:
4 months ago
#9
Could you merge it?
@ellatrix commented on PR #6495:
4 months ago
#10
Should https://github.com/WordPress/gutenberg/pull/61351 be included here or in a separate backport?
🚧
Trac ticket: https://core.trac.wordpress.org/ticket/61023