Make WordPress Core

Opened 6 weeks ago

Closed 4 weeks ago

#61034 closed defect (bug) (fixed)

Twenty Fourteen: Pullquote block needs base font size while supporting custom font size

Reported by: sabernhardt's profile sabernhardt Owned by: karmatosed's profile karmatosed
Milestone: 6.6 Priority: normal
Severity: normal Version: trunk
Component: Bundled Theme Keywords: has-patch commit
Focuses: css Cc:

Description

[57989] changed the default font size of Pullquote blocks, Quote blocks, and blockquote elements in the Classic block/Classic Editor from 19px.

  • Pullquote blocks increased to 24px
  • Quote blocks and Classic quotes decreased to 16px

Attachments (4)

Quote font sizes WordPress 6.5.png (67.8 KB) - added by sabernhardt 6 weeks ago.
19px font size for blockquote plus Pullquote blocks with WordPress 6.5 and Twenty Fourteen 3.9
Quote font sizes WP 6.6-alpha.png (71.4 KB) - added by sabernhardt 6 weeks ago.
in WordPress trunk, the default font size changed for blockquote elements and Pullquote blocks
61034.diff (1.9 KB) - added by sabernhardt 5 weeks ago.
restores default 19px for blockquote elements and inherits selected font sizes in Pullquote blocks
61034.add-appearance.diff (2.3 KB) - added by sabernhardt 5 weeks ago.
option to support typography Appearance selections in addition to font size

Download all attachments as: .zip

Change History (12)

#1 @sabernhardt
6 weeks ago

I made a set of blocks to show the default font size plus the Large preset and a custom font size.

@sabernhardt
6 weeks ago

19px font size for blockquote plus Pullquote blocks with WordPress 6.5 and Twenty Fourteen 3.9

#2 @karmatosed
6 weeks ago

  • Keywords commit added

I can confirm agreement that this should be committed so adding those keywords and I will follow through with this. Thank you.

@sabernhardt
6 weeks ago

in WordPress trunk, the default font size changed for blockquote elements and Pullquote blocks

#3 @karmatosed
6 weeks ago

  • Keywords needs-patch added; has-patch commit removed

@sabernhardt would you be able to re-attach the patch to this so I can commit it? It isn't attached to this new ticket.

#4 @karmatosed
5 weeks ago

  • Keywords reporter-feedback added

@sabernhardt
5 weeks ago

restores default 19px for blockquote elements and inherits selected font sizes in Pullquote blocks

@sabernhardt
5 weeks ago

option to support typography Appearance selections in addition to font size

#5 @sabernhardt
5 weeks ago

  • Keywords has-patch added; needs-patch reporter-feedback removed

[57631] had a more elaborate way to fix the Pullquote's typography settings in Twenty Twenty-One, which I do not think is necessary for Twenty Fourteen. However, I should mention that the font weight and font style (in Appearance settings) would be more block options to support in Twenty Fourteen, which probably could be more appropriate on another ticket.

With 61034.diff:

  • The quote text honors font size settings (preset or custom), though it does not affect the citation.
  • The Appearance settings still would not affect front or back end, for weight or style.
  • The Letter spacing and Text decoration selections work.
  • The Letter case affects quote text but not citation.

#6 @karmatosed
4 weeks ago

  • Keywords commit added
  • Owner set to karmatosed
  • Status changed from new to assigned

#7 @karmatosed
4 weeks ago

I think that adding in the typography Appearance selections in addition is useful as those missing is a strange experience, so choosing that diff to commit.

#8 @karmatosed
4 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 58053:

Twenty Fourteen: Adds base font size to pullquote block.

The pullquote block needed the base font size adding back in. This also adds in support for appearance settings for weight and style in addition to the original ticket. This fixes a previous commit which changed the default font size of pullquote blocks, quote blocks and blockquotes.

Props sabernhardt.
Fixes #61034.

Note: See TracTickets for help on using tickets.