Make WordPress Core

Opened 5 months ago

Closed 3 months ago

#61042 closed defect (bug) (wontfix)

Twenty Fifteen: Group block text color setting not applied to Pullquote block

Reported by: nidhidhandhukiya's profile nidhidhandhukiya Owned by:
Milestone: Priority: normal
Severity: normal Version: 6.5
Component: Bundled Theme Keywords: has-testing-info has-patch close
Focuses: css Cc:

Description

Steps to reproduce the issue :-

  1. Activate Twenty Fifteen theme.
  2. Take Group block.
  3. Add Paragraph block inside group block.
  4. Add pullquote block inside group block.
  5. Apply text color from the group block settings.

Now check both the side in editor and front end you can able to see there is no difference in font-color of citation in both the side.
I have attached video for better understanding.
Video URL :- https://share.cleanshot.com/0SV4HM4RtnBCPg5RgcjX

Attachments (1)

61042.patch (996 bytes) - added by nidhidhandhukiya 5 months ago.

Download all attachments as: .zip

Change History (8)

#1 @devsahadat
5 months ago

  • Keywords has-testing-info has-patch added

@nidhidhandhukiya , I was about to submit the patch and then found you already submitted one. Great work. I tested your patch and it's working perfectly.

#2 @pooja1210
4 months ago

Hi,

Test Report
Patch tested - https://core.trac.wordpress.org/attachment/ticket/61042/61042.patch

Environment:
WordPress: 6.5.3
PHP: 8.1
Browser: Chrome 125
OS: macOS

Theme: Twenty Fifteen

Expected Result: The font colour for the citation should be changed as per settings and should look fine on the frontend and backend and this is working as expected.

Screenshots:
Before: https://prnt.sc/q8s0che0fpHm
After: https://prnt.sc/cjVPz5KeJClY

Thanks

#3 @karmatosed
3 months ago

  • Milestone changed from Awaiting Review to 6.6

Thank you, going to put this as a proposal for this release then if it's got a patch and test.

#4 @karmatosed
3 months ago

  • Keywords needs-testing added

#5 @hmbashar
3 months ago

Test Report

Patch tested: 61042.patch

Environment

  • WordPress: 6.6-alpha-57778-src
  • PHP: 8.3.7
  • Server: nginx/1.25.4
  • Database: mysqli (Server: 8.3.0 / Client: mysqlnd 8.3.7)
  • Browser: Chrome 125.0.0.0
  • OS: macOS
  • Theme: Twenty Fifteen 3.7
  • MU Plugins: None activated
  • Plugins:
    • FakerPress 0.6.6
    • Test Reports 1.1.0

Actual Results

  1. ✅ Issue resolved with patch.

Screenshots

Editor Before Patch Editor After Patch
https://i.ibb.co/9Yqsv2L/Before-Editor.png https://i.ibb.co/56TH4vj/After-Editor.png
Frontend Before Patch Frontend After Patch
https://i.ibb.co/MRdbkp5/Before-frontend.png https://i.ibb.co/1zgwRDV/After-Frontend.png

#6 @sabernhardt
3 months ago

  • Focuses css added
  • Keywords close added; needs-testing removed
  • Summary changed from Twenty Fifteen Group block color setting not applied to pullquote block. to Twenty Fifteen: Group block text color setting not applied to Pullquote block

I do not agree that everyone who sets a text color on a parent block such as Group—or Column—would always want that applied automatically to inner blocks and/or elements within those.

However, on #59801 I could suggest that we remove the #333 color on the citation for Twenty Fifteen because the Pullquote's default text colors for quote and citation have been identical on the front end since WordPress 5.9, changing the theme's design.

#7 @karmatosed
3 months ago

  • Milestone 6.6 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

After some consideration also agree with your sentiment @sabernhardt here:

I do not agree that everyone who sets a text color on a parent block such as Group—or Column—would always want that applied automatically to inner blocks and/or elements within those.

As noted on #59801 there could be a suggestion that eases this, so let's go with that. Thank you everyone for the consideration here.

Note: See TracTickets for help on using tickets.