Context Navigation

← Previous Ticket
Next Ticket →

#61072 closed enhancement (fixed)

HTML API: Add custom text decoder

Reported by:	dmsnell	Owned by:	dmsnell
Priority:	normal	Milestone:	6.6
Component:	HTML API	Version:	6.6
Severity:	normal	Keywords:	has-patch needs-dev-note
Cc:		Focuses:

Description

Provide a custom decoder for strings coming from HTML attributes and
markup. This custom decoder is necessary because of deficiencies in
PHP's html_entity_decode() function:

It isn't aware of 720 of the possible named character references in HTML, leaving many out that should be translated.

It isn't aware of the ambiguous ampersand rule, which allows conversion of character references in certain contexts when they are missing their closing ;.

It doesn't draw a distinction for the ambiguous ampersand rule when decoding attribute values instead of markup values.

This decoder will also provide some conveniences, such as making a
single-pass and interruptable decode operation possible. This will
provide a number of opportunities to optimize detection and decoding
of things like value prefixes, and whether a value contains a given
substring.

Change History (8)

#1 @dmsnell
2 years ago

Milestone Awaiting Review → 6.6

I'm not sure why the PR isn't auto-linking: https://github.com/WordPress/wordpress-develop/pull/6387

This ticket was mentioned in Slack in #core-performance by dmsnell. View the logs.

2 years ago

This ticket was mentioned in Slack in #core by dmsnell. View the logs.

2 years ago

This ticket was mentioned in Slack in #core by oglekler. View the logs.

2 years ago

#5 @dmsnell
2 years ago

Owner set to dmsnell
Resolution → fixed
Status new → closed

In 58281:

HTML API: Add custom text decoder.

Provides a custom decoder for strings coming from HTML attributes and
markup. This custom decoder is necessary because of deficiencies in
PHP's html_entity_decode() function:

It isn't aware of 720 of the possible named character references in HTML, leaving many out that should be translated.

It isn't aware of the ambiguous ampersand rule, which allows conversion of character references in certain contexts when they are missing their closing ;.

It doesn't draw a distinction for the ambiguous ampersand rule when decoding attribute values instead of markup values.

Use of html_entity_decode() requires manually passing non-default paramter values to ensure it decodes properly.

This decoder also provides some conveniences, such as making a
single-pass and interruptable decode operation possible. This will
provide a number of opportunities to optimize detection and decoding
of things like value prefixes, and whether a value contains a given
substring.

Developed in https://github.com/WordPress/wordpress-develop/pull/6387
Discussed in https://core.trac.wordpress.org/ticket/61072

Props dmsnell, gziolo, jonsurrell, jorbin, westonruter, zieladam.
Fixes #61072.

#6 @dmsnell
2 years ago

Keywords needs-dev-note added

#7 @dmsnell
2 years ago

Dev note incorporated into Updates to the HTML API

#8 @westonruter
8 months ago

In 61283:

Docs: Fix return type for WP_HTML_Decoder::read_character_reference().

Developed in https://github.com/WordPress/wordpress-develop/pull/8945

Follow-up to [58281].

Props justlevine.
See #64238, #61072.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#61072 closed enhancement (fixed)

HTML API: Add custom text decoder

Description

Change History (8)

#1 @dmsnell 2 years ago

This ticket was mentioned in ​Slack in #core-performance by dmsnell. ​View the logs. 2 years ago

This ticket was mentioned in ​Slack in #core by dmsnell. ​View the logs. 2 years ago

This ticket was mentioned in ​Slack in #core by oglekler. ​View the logs. 2 years ago

#5 @dmsnell 2 years ago

#6 @dmsnell 2 years ago

#7 @dmsnell 2 years ago

#8 @westonruter 8 months ago