#61080 closed defect (bug) (fixed)
HTML API: Tests should use expectedIncorrectUsage phpunit annotation
Reported by: | jonsurrell | Owned by: | jonsurrell |
---|---|---|---|
Milestone: | 6.6 | Priority: | normal |
Severity: | normal | Version: | |
Component: | HTML API | Keywords: | has-patch has-unit-tests |
Focuses: | Cc: |
Description
Some tests in the HTML API test suite use setExpectedIncorrectUsage
. The annotation @expectedIncorrectUsage
can be used to simplify the tests.
Change History (5)
This ticket was mentioned in PR #6449 on WordPress/wordpress-develop by @jonsurrell.
8 months ago
#1
- Keywords has-patch has-unit-tests added
8 months ago
#2
When I added a commit to prevent calling _doing_it_wrong()
the test didn't fail locally, but it did mark it as risky, which I believe is because it makes no assertions.
Thankfully, the CI job failed.
That pretty-much confirms what I wanted to know, so I'll remove my commit and we should be able to merge this.
Note: See
TracTickets for help on using
tickets.
Trac ticket: https://core.trac.wordpress.org/ticket/61080