![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#61080 closed defect (bug) (fixed)
HTML API: Tests should use expectedIncorrectUsage phpunit annotation
| Reported by: | jonsurrell | Owned by: | jonsurrell |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.6 |
| Component: | HTML API | Version: | |
| Severity: | normal | Keywords: | has-patch has-unit-tests |
| Cc: | Focuses: |
Description
Some tests in the HTML API test suite use setExpectedIncorrectUsage. The annotation @expectedIncorrectUsage can be used to simplify the tests.
Change History (5)
This ticket was mentioned in PR #6449 on WordPress/wordpress-develop by @jonsurrell.
2 years ago
#1
- Keywords has-patch has-unit-tests added
2 years ago
#2
When I added a commit to prevent calling _doing_it_wrong() the test didn't fail locally, but it did mark it as risky, which I believe is because it makes no assertions.
Thankfully, the CI job failed.
That pretty-much confirms what I wanted to know, so I'll remove my commit and we should be able to merge this.
Note:
See TracTickets
for help on using tickets.
Trac ticket: https://core.trac.wordpress.org/ticket/61080