Make WordPress Core

Opened 5 months ago

Closed 3 months ago

Last modified 3 months ago

#61082 closed defect (bug) (fixed)

Twenty Twenty-One: Font size difference between editor & frontend in Latest Comments block

Reported by: pitamdey's profile pitamdey Owned by: karmatosed's profile karmatosed
Milestone: 6.6 Priority: normal
Severity: normal Version: 5.8
Component: Bundled Theme Keywords: has-screenshots has-patch needs-testing commit
Focuses: css Cc:

Description

In Twenty Twenty-One Theme, It seems like the latest block has a difference in the font-size between the editor side and the fronted side. Kindly check it
I have attached the screenshots for both side

Attachments (3)

Screenshot 2024-04-26 at 11.07.07 AM.png (325.5 KB) - added by pitamdey 5 months ago.
Editor View
Screenshot 2024-04-26 at 11.07.31 AM.png (245.2 KB) - added by pitamdey 5 months ago.
Frontend View
61082.diff (8.2 KB) - added by sabernhardt 5 months ago.
checks block for special font size before applying default, uses inherit for nested elements, and copies front-end styles to the editor stylesheet

Download all attachments as: .zip

Change History (9)

@sabernhardt
5 months ago

checks block for special font size before applying default, uses inherit for nested elements, and copies front-end styles to the editor stylesheet

#1 @sabernhardt
5 months ago

  • Focuses css added
  • Keywords has-patch needs-testing added
  • Milestone changed from Awaiting Review to Future Release
  • Summary changed from Twenty Twenty-One : Font Size difference between editor & frontend in Latest comments block to Twenty Twenty-One: Font size difference between editor & frontend in Latest Comments block
  • Version set to 5.8

Yes, the front end styles have a specific font size for the comments—plus their dates and excerpt paragraphs—without comparable styles in the _editor.scss file (since the theme's first version and in Seedlet). I selected 5.8 for the version because that is when the block was available in the Widgets area.

#2 @karmatosed
3 months ago

  • Keywords commit added
  • Owner set to karmatosed
  • Status changed from new to assigned

I am going to look through this and test because it looks like we might be able to get through into a commit. Thank you everyone.

#3 @karmatosed
3 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 58464:

Twenty Twenty-One: Fixes font size difference in latest comments block.

The font size was different in the last comments block depending on if it was in the editor or front. This resolves that by checking block for special font size before applying default and using inherit for nested elements.

Props pitamdey, sabernhardt.
Fixes #61082.

#4 @karmatosed
3 months ago

In 58465:

Twenty Twenty-One: Fixes compiling tests [58464].

Compiling fix to sort tests.

See #61082.

#5 @kebbet
3 months ago

With changesets during current major release, please milestone this ticket to 6.6 @karmatosed!

#6 @karmatosed
3 months ago

  • Milestone changed from Future Release to 6.6
Note: See TracTickets for help on using tickets.