Make WordPress Core

Opened 3 weeks ago

Last modified 2 weeks ago

#61110 new defect (bug)

Editor: Fix block template files query for a post-type

Reported by: mamaduka's profile Mamaduka Owned by:
Milestone: 6.6 Priority: normal
Severity: normal Version: 6.3
Component: Editor Keywords: has-patch has-unit-tests
Focuses: Cc:

Description

Sync ticket for https://github.com/WordPress/gutenberg/pull/61244.

Fixes a bug where block template files that aren't defined in theme.json's customTemplates were missing from get_block_templates for a post-type query.

The custom template files with no associated post-types are available for all post-types.

Note: Original regression was introduced in r55687 but only started affecting Editor users in WP 6.5.

Change History (4)

This ticket was mentioned in PR #6468 on WordPress/wordpress-develop by @Mamaduka.


3 weeks ago
#1

  • Keywords has-patch has-unit-tests added

@Mamaduka commented on PR #6468:


3 weeks ago
#2

Thanks for testing, @creativecoder!

I added the explanatory comment for the data provider.

P.S. Comment support for JSON would have been handy at this moment :)

#3 @grantmkin
3 weeks ago

Noting here that there is discussion about the performance impact of this fix in the Gutenberg PR, starting with this comment: https://github.com/WordPress/gutenberg/pull/61244#issuecomment-2089797625

#4 @jorbin
2 weeks ago

  • Milestone changed from 6.5.3 to 6.6

It was discussed on the PR to punt this from 6.5.3 and I agree so moving to 6.6 and then it can get moved to 6.5.4 for later consideration.

See: https://github.com/WordPress/gutenberg/pull/61244#issuecomment-2090756404

Note: See TracTickets for help on using tickets.