Make WordPress Core

Opened 7 weeks ago

Closed 3 weeks ago

Last modified 3 weeks ago

#61119 closed enhancement (fixed)

Global Styles: Add scoping of feature level selectors for custom block style variations

Reported by: aaronrobertshaw's profile aaronrobertshaw Owned by: isabel_brison's profile isabel_brison
Milestone: 6.6 Priority: normal
Severity: normal Version: trunk
Component: Editor Keywords: gutenberg-merge has-patch has-unit-tests
Focuses: Cc:

Description

This ticket tracks the backporting of PHP files for the following Gutenberg changes:

https://github.com/WordPress/gutenberg/pull/61033

This change ensures that feature-level selectors for block style variations are correctly scoped when generating a theme.json stylesheet.

Change History (7)

This ticket was mentioned in PR #6475 on WordPress/wordpress-develop by @aaronrobertshaw.


7 weeks ago
#1

  • Keywords has-patch has-unit-tests added

Syncs the changes from:

These changes ensure that custom feature-level selectors for style nodes are correctly scoped when generating a theme.json stylesheet

Unit tests: npm run test:php -- --filter Tests_Theme_wpThemeJson

https://github.com/WordPress/wordpress-develop/assets/60436221/688d2d0b-0163-465d-a713-f08bb96d8b81

Trac ticket: https://core.trac.wordpress.org/ticket/61119

@vcanales commented on PR #6475:


4 weeks ago
#2

👋 @audrasjb @aaronrobertshaw any updates here?

@aaronrobertshaw commented on PR #6475:


4 weeks ago
#3

All the feedback to date has been addressed and we're just waiting on an approval.

#4 @isabel_brison
3 weeks ago

  • Owner set to isabel_brison
  • Resolution set to fixed
  • Status changed from new to closed

In 58244:

Editor: Add scoping of feature level global styles selectors.

Ensures that feature-level selectors for block style variations are correctly scoped when generating a theme.json stylesheet.

Props aaronrobertshaw, audrasjb, vcanales, isabel_brison.
Fixes #61119.

@isabel_brison commented on PR #6475:


3 weeks ago
#5

Committed in r58244.

#6 @kebbet
3 weeks ago

Please milestone in 6.6 @isabel_brison

#7 @isabel_brison
3 weeks ago

  • Milestone changed from Awaiting Review to 6.6

Oh sorry @kebbet, didn't notice the ticket wasn't milestoned already!

Note: See TracTickets for help on using tickets.